Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done?
Core Implementation
✅ Task 6.1 - SQS Integration & Batch Processing
catalogBatchProcesslambda function in Product Service stackcatalogItemsQueueSQS queue with batch size of 5 messages✅ Task 6.2 - Import Service Enhancement
importFileParserlambda function to send CSV records to SQS instead of CloudWatch logging✅ Task 6.3 - SNS Integration
createProductTopicSNS topic with email subscriptioncatalogBatchProcesslambda to send SNS notifications after product creationdamirstanojevic@gmail.comAdditional Enhancements
✅ Unit Tests
catalogBatchProcesslambda function✅ SNS Filter Policies & Multiple Subscriptions
damirstanojevic+expensive@gmail.comfor products > $25damirstanojevic+rock@gmail.comfor Rock genre productsArchitecture & Infrastructure
✅ CDK Stack Configuration
Product Schema
API Endpoints
Product Service API
https://uf4ds80g46.execute-api.us-east-1.amazonaws.com/prodGET /productsGET /products/{productId}POST /productsImport Service API
https://i6nl249ace.execute-api.us-east-1.amazonaws.com/prodGET /import?fileName={filename}(returns signed URL for CSV upload)Technical Implementation Details
SQS Flow
CSV Upload → S3 → importFileParser → SQS catalogItemsQueue → catalogBatchProcess → DynamoDBSNS Notifications
Product Creation → SNS createProductTopic → Email Subscriptions → Filtered DistributionData Processing
Testing & Validation
Test Coverage
Test Data
Deployment & Configuration
AWS Resources Created
Environment Variables
PRODUCTS_TABLE,STOCK_TABLE,CREATE_PRODUCT_TOPIC_ARNCATALOG_ITEMS_QUEUE_URL,IMPORT_BUCKET_NAMEAdditional Scope
Status: ✅ COMPLETE - All tasks implemented and deployed successfully
Branch:
task-6from latest masterReady for: Code review and merge to master branch