Make Set_UniformColor a member function instead of a template#1966
Open
slipher wants to merge 2 commits intoDaemonEngine:masterfrom
Open
Make Set_UniformColor a member function instead of a template#1966slipher wants to merge 2 commits intoDaemonEngine:masterfrom
slipher wants to merge 2 commits intoDaemonEngine:masterfrom
Conversation
Member
|
Nice! I guess I can do the same with a similar dispatcher in my GL4ES branch! |
illwieckz
reviewed
May 6, 2026
| u_ColorModulateColorGen_Uint( this ), | ||
| u_Color_Float( this ), | ||
| u_Color_Uint( this ), | ||
| u_ColorModulateColorGen_Dual( this ), |
Member
There was a problem hiding this comment.
Maybe _Multi is more generic for a naming convention of one thing dispatching to many?
Member
Author
There was a problem hiding this comment.
OK now I got both of them.
slipher
force-pushed
the
uniform-notemplate
branch
from
bdede59 to
f98f142
Compare
Get rid of SetUniform_Color and SetUniform_ColorModulateColorGen template functions and make them member functions of classes which inherit the two variants of each uniform.
slipher
force-pushed
the
uniform-notemplate
branch
from
f98f142 to
89a54ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.