Skip to content

Skip lightmap + deluxegrid shader permutations compilation and skip “proxy” shader compilation#1927

Merged
illwieckz merged 3 commits intofor-0.56.0/syncfrom
illwieckz/shader-compilation
Mar 14, 2026
Merged

Skip lightmap + deluxegrid shader permutations compilation and skip “proxy” shader compilation#1927
illwieckz merged 3 commits intofor-0.56.0/syncfrom
illwieckz/shader-compilation

Conversation

@illwieckz
Copy link
Member

@illwieckz illwieckz commented Mar 9, 2026

@illwieckz illwieckz force-pushed the illwieckz/shader-compilation branch from df0edaa to db83052 Compare March 9, 2026 14:48
@illwieckz illwieckz changed the title Skip some shader permutation compilation and skip “proxy” shader compilation Skip lightmap + deluxegrid shader permutation compilation and skip “proxy” shader compilation Mar 9, 2026
@illwieckz illwieckz changed the title Skip lightmap + deluxegrid shader permutation compilation and skip “proxy” shader compilation Skip lightmap + deluxegrid shader permutations compilation and skip “proxy” shader compilation Mar 9, 2026
@illwieckz illwieckz force-pushed the illwieckz/shader-compilation branch 2 times, most recently from 3c889e5 to 7ee8d4a Compare March 9, 2026 15:08
@slipher
Copy link
Member

slipher commented Mar 9, 2026

For skipping lightmap + grid deluxe I believe I have a simpler implementation in the first two commits of #1920.

@illwieckz
Copy link
Member Author

illwieckz commented Mar 9, 2026

For skipping lightmap + grid deluxe I believe I have a simpler implementation in the first two commits of #1920.

If that PR has generic fixes that can be merged without the rest of the draft, please submit them separately. =)

@slipher
Copy link
Member

slipher commented Mar 11, 2026

For skipping lightmap + grid deluxe I believe I have a simpler implementation in the first two commits of #1920.

Can now be found in #1928

@illwieckz illwieckz force-pushed the illwieckz/shader-compilation branch from 7ee8d4a to 4d70088 Compare March 12, 2026 12:50
@illwieckz
Copy link
Member Author

Commit for “lightmap + grid deluxe skip” removed in favor of (now merged):

Removed commit from:

It was initially included in that branch because it helped me to debug.
I still want to merge it, but it already has a dedicated PR.

@slipher
Copy link
Member

slipher commented Mar 14, 2026

LGTM

@illwieckz illwieckz merged commit 5753a7d into for-0.56.0/sync Mar 14, 2026
9 checks passed
@illwieckz illwieckz deleted the illwieckz/shader-compilation branch March 14, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants