Skip to content

Fix console crash and console key input #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VReaperV wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix console crash and console key input #1880

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80839fc
Fix crash in console auto-complete with cursor == 0
VReaperV Dec 26, 2025
745136e
Fix console key being printed into the console
VReaperV Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/engine/framework/ConsoleField.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ namespace Console {
Cmd::Args args(std::string(commandStart, commandEnd));
int argNum = args.Argc() - 1;
std::string prefix;
if (!args.Argc() || Str::cisspace(GetText()[GetCursorPos() - 1])) {
if (!args.Argc() || !GetCursorPos() || Str::cisspace(GetText()[GetCursorPos() - 1])) {
Copy link
Copy Markdown
Member

@slipher slipher Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way things initially go wrong is with the subtraction underflow in std::string commandText = Str::UTF32To8(GetText().substr(1, GetCursorPos() - 1));. Would be nicer to return before that

argNum++;
} else {
prefix = args.Argv(argNum);
Expand Down