-
Notifications
You must be signed in to change notification settings - Fork 0
Dynamic Link Deployment Test - Dev Site #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
implementation issues.
implementation error
We now just use the headers available to the R2 bucket and get a speed boost!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements dynamic WASM link deployment and refactors asset preloading and related components.
- Revamps
assetPreloader.tsto use dynamic imports, conditional caching, and ETag checks - Updates the
createWasmCanvashook with stricter typing, visibility handling, and code cleanup - Applies formatting, naming, and structural refactors across various components and CSS
Reviewed Changes
Copilot reviewed 40 out of 46 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils/assetPreloader.ts | Revamped asset preloader for dynamic WASM imports and caching logic |
| src/index.tsx | Minor update to error message punctuation |
| src/index.css | Reformatted font-family declarations |
| src/components/hooks/createWasmCanvas.ts | Refactored canvas hook with improved typing and lifecycle management |
| src/components/WasmIframeWrapper.tsx | Added createEffect and refined iframe messaging |
| src/components/Wallet/utils/format.ts | Added trailing comma in options object for readability |
| src/components/Wallet/WalletContext.tsx | Refactored context naming, storage loading/saving, and hooks |
| src/components/Wallet/WalletApp.tsx | Enhanced JSX formatting and event handlers |
| src/components/WGPUNotification/WGPUNotificationWindow.tsx | Consolidated imports and improved drag/resize handling |
| src/components/WGPUNotification/WGPUNotificationApp.tsx | Switched to Show for conditional UI in WebGPU support checks |
| src/components/Theme/theme.css | Reformatted multi-line CSS properties |
| src/components/Theme/ThemeSwitcher.tsx | Removed unused ThemeSwitcher component |
| src/components/Theme/ThemeContext.tsx | Refined context naming and provider implementation |
| src/components/StatsList.tsx | Simplified list rendering and renamed export |
| src/components/SplashScreen.tsx | Modularized splash screen logic, added untrack, improved hooks |
| src/components/SplashScreen.module.css | Reformatted background and size declarations |
| src/components/ProgramWindow/programContext.tsx | Improved TypeScript types and program registry normalization |
| src/components/ProgramWindow/ProgramWindow.tsx | Refined drag-and-drop logic and JSX structure |
| src/components/ProgramEventDemo.tsx | Updated imports, enum naming, and demo event wiring |
Comments suppressed due to low confidence (4)
src/components/hooks/createWasmCanvas.ts:433
- [nitpick] The variable
shouldrunInitdoesn’t follow camelCase convention. Rename it toshouldRunInitfor consistency.
const shouldrunInit = enabled(); // Depend on enabled prop accessor
src/components/hooks/createWasmCanvas.ts:436
- [nitpick] The variable
iswasmReadyshould beisWasmReadyto follow camelCase and clearly indicate the acronym.
const iswasmReady = isReady(); // Depend on ready signal
src/components/hooks/createWasmCanvas.ts:440
- [nitpick] The variable
needsinitializationshould beneedsInitializationto follow camelCase convention and improve readability.
canvas && shouldrunInit && !iswasmReady && !currentError && !currentBridge;
src/components/StatsList.tsx:39
- [nitpick] The default export
statsListis lowercase, while component names should be PascalCase. Rename it toStatsListfor consistency with React/Solid conventions.
export default statsList;
Dynamic Link Deployment Test - Dev Site (#7)
This PR includes the code necessary for dynamic link imports for the WASM.