Add simplified SPINE script for modern spine-prod configs#79
Open
Add simplified SPINE script for modern spine-prod configs#79
spine-prod configs#79Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new script
run_spine.spine-prod.shthat sources spine-prod'sconfigure.sh(so that included yamls are properly found, etc.).The new script does away with the temp-dir creation / template substitution complexity of the old script, since it is no longer necessary with modern configs.
The interpretation of
ND_PRODUCTION_SPINE_CONFIGis simplified: It's just the path relative torun-mlreco; no more magic. So if you want to use a config fromspine-prod, it'll look likeinstall/spine-prod/.... If you want to use a config maintained within ND_Production, it'll start withconfigs/....Also, this catches up with SPINE's ongoing campaign to replace underscores with hyphens. A symlink from
spine-prodtospine_prodis created to ensure backward compatibility.Addresses #76
TODO:
infer/nd-lar/full_chain_260310.yaml