Skip to content

fix: #219 show tables' all fields #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cythia828 merged 1 commit into from
May 20, 2026
+0 −25
Merged

fix: #219 show tables' all fields #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions website/src/languages/helpers/completionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,19 +304,6 @@ const getColumnCompletions = async (
const words = wordRanges.map((wr) => wr.text);
const result: ICompletionItem[] = [];

// Extract already selected columns from QUERY_RESULT to filter them out
const queryResultEntity = entities.find(
(entity) => entity.entityContextType === EntityContextType.QUERY_RESULT
) as CommonEntityContext | undefined;

const selectedColumns = new Set<string | languages.CompletionItemLabel>();
queryResultEntity?.columns?.forEach((col) => {
const columnName = col[AttrName.alias]?.text || getPureEntityText(col.text);
if (columnName) {
selectedColumns.add(columnName);
}
});

// All tables defined in the context
const allTableDefinitionEntities =
(entities?.filter(
Expand Down Expand Up @@ -511,18 +498,6 @@ const getColumnCompletions = async (
}
}

// Filter out already selected columns in QUERY_RESULT
if (selectedColumns.size > 0) {
return result.filter((item) => {
const columnName =
(item as EnhancedCompletionItem)._columnText ||
(typeof item.label === 'string'
? item.label
: (item.label as EnhancedCompletionItem).label);
return !selectedColumns.has(columnName);
});
}

return result;
};

Expand Down
Loading