-
Notifications
You must be signed in to change notification settings - Fork 19
fix: improve type safety and support synchronous return for strings #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jin-sir
wants to merge
2
commits into
DTStack:master
Choose a base branch
from
jin-sir:fix_toBase64
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,41 @@ | ||
| import toBase64 from '../index'; | ||
|
|
||
| describe('toBase64', () => { | ||
| it('should return a resolved promise with undefined when input is undefined', async () => { | ||
| await expect(toBase64(undefined)).resolves.toBeUndefined(); | ||
| it('should return undefined when input is undefined', () => { | ||
| expect(toBase64(undefined)).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('should return a resolved promise with null when input is null', async () => { | ||
| await expect(toBase64(null)).resolves.toBeNull(); | ||
| it('should return undefined when input is null', () => { | ||
| expect(toBase64(null)).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('should encode a string to Base64 using js-base64', async () => { | ||
| await expect(toBase64('hello')).resolves.toBe('aGVsbG8='); | ||
| }); | ||
|
|
||
| it('should encode a number to Base64 using js-base64', async () => { | ||
| await expect(toBase64(12345)).resolves.toBe('MTIzNDU='); | ||
| it('should encode a string to Base64 synchronously', () => { | ||
| expect(toBase64('hello')).toBe('aGVsbG8='); | ||
| }); | ||
|
|
||
| it('should encode a Blob to Base64', async () => { | ||
| const blob = new Blob(['hello world'], { type: 'text/plain' }); | ||
| const base64Result = await toBase64(blob); | ||
| expect(base64Result.startsWith('data:text/plain;base64,')).toBe(true); | ||
| expect(String(base64Result).startsWith('data:text/plain;base64,')).toBe(true); | ||
| }); | ||
|
|
||
| it('should encode a File to Base64', async () => { | ||
| const file = new File(['file content'], 'test.txt', { type: 'text/plain' }); | ||
| const base64Result = await toBase64(file); | ||
| expect(base64Result.startsWith('data:text/plain;base64,')).toBe(true); | ||
| expect(String(base64Result).startsWith('data:text/plain;base64,')).toBe(true); | ||
| }); | ||
|
|
||
| it('should reject when FileReader encounters an error', async () => { | ||
| const mockBlob = new Blob(['test'], { type: 'text/plain' }); | ||
| jest.spyOn(FileReader.prototype, 'readAsDataURL').mockImplementation(function () { | ||
| setTimeout(() => this.onerror && this.onerror(new Error('FileReader error'))); | ||
| jest.spyOn(FileReader.prototype, 'readAsDataURL').mockImplementation(function ( | ||
| this: FileReader | ||
| ) { | ||
| setTimeout(() => { | ||
| if (this.onerror) { | ||
| this.onerror(new ProgressEvent('error') as ProgressEvent<FileReader>); | ||
| } | ||
| }); | ||
| }); | ||
| await expect(toBase64(mockBlob)).rejects.toThrow('FileReader error'); | ||
| await expect(toBase64(mockBlob)).rejects.toBeInstanceOf(ProgressEvent); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.