Skip to content

Feature (#4347) : Enable language specific DSpace links via lang quer…#5241

Open
guillermo-escire wants to merge 2 commits intoDSpace:mainfrom
guillermo-escire:feature/4347
Open

Feature (#4347) : Enable language specific DSpace links via lang quer…#5241
guillermo-escire wants to merge 2 commits intoDSpace:mainfrom
guillermo-escire:feature/4347

Conversation

@guillermo-escire
Copy link
Contributor

…y param

References

Fixes #4347

Description

Enable DSpace Angular frontend to respect a lang query parameter in the URL.
This allows linking directly to a specific language version (e.g., French, English, Spanish) and ensures the language selector works correctly afterward.

Instructions for Reviewers

List of changes in this PR:

  • Added checkQueryParamLanguage() in LocaleService to read lang from the URL and apply it on first load.
  • Modified applyLangIfValid() to set the current language and remove the lang query param from the URL.
  • Ensured that changing the language via the selector overrides any previously applied URL language.
  • Added comments for clarity on private methods.

Testing instructions:

  1. Open in a fresh browser or incognito mode.
  2. Go to http://localhost:4000/home?lang=fr → page should display in French, URL should remove ?lang=fr.
  3. Change the language using the selector → page should stay in the newly selected language.
  4. Repeat with ?lang=en and ?lang=es to verify all supported languages.
  5. Verify that ESLint passes: npm run lint.
  6. Ensure no regression in other DSpace pages.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added i18n / l10n Internationalisation and localisation, related to message catalogs new feature 1 APPROVAL pull request only requires a single approval to merge labels Mar 5, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs new feature

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Enable language specific DSpace Links

2 participants