fix: record current DOS Testnet ENSv2 deployment - #9
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the deployment configuration for the dos-testnet-3939 network, modifying the deployment blocks, deployment timestamp, transaction hashes, and contract addresses. There are no review comments, and I have no feedback to provide.
There was a problem hiding this comment.
Code Review
This pull request updates the deployment configuration for the DOS testnet (chainId 3939), including new block numbers, transaction hashes, and contract addresses. The review feedback suggests formatting the new contract addresses using their checksummed (ERC-55) representations to maintain consistency with the previous deployment file and prevent potential compatibility issues with strict validation tools.
| "wrappedDOS": "0xc647ccf449dec38bb8b7272e60fc14b3548c9547", | ||
| "contractNamerImplementation": "0x069056b2ae8fd8c071efb827c5af73a0996840e1", | ||
| "contractNamer": "0x030eec847cf5d9d1c4a0b4e0459d130d0b35577c", | ||
| "verifiableFactory": "0xb86bb608e6afd7a8eb209510c01bb859a7c315f1", | ||
| "labelStore": "0x38fc582690c3f28099087a88520056afab08ce5f", | ||
| "rootRegistry": "0xb17fec6fe18ac0b7f3dd934495e84ec06cf88564", | ||
| "dosRegistry": "0x8a2730c903d93b2116fab3d9110c7d585f7b5a91", | ||
| "reverseRegistry": "0x641ee4711013ee40b34fae860894227c4771f273", | ||
| "priceOracle": "0x1f31e05948769174da256d0484b8f26cfd3d8c97", | ||
| "dosRegistrar": "0x27a3b7ff0ef7fb96d49eb50b069570f407387362", | ||
| "permissionedResolverImplementation": "0xfa579733d7c5a21b5d3c4399d3d6ef89fc3a3720", | ||
| "userRegistryImplementation": "0x8291f1c6aef2acbc58f3fe11c9e4ec0d3d4ae904", | ||
| "gatewayProvider": "0xcb20a0c349f079b8bd403ea8f668fe3da49e981f", | ||
| "universalResolver": "0x5a34c9fb9806239ed61f1570c51edb198333fbea", | ||
| "reverseRegistrar": "0x3cd8bddeb177492c5e521c3b82179887f472f018", | ||
| "smokeResolver": "0xee4b6427b88b8aa30fe2295139b8b2216f32d51b" |
There was a problem hiding this comment.
The contract addresses in the contracts block are currently all lowercase. In the previous version of this deployment file, almost all contract addresses were checksummed (ERC-55 compliant).
To maintain consistency and prevent potential issues with tools or libraries that strictly validate ERC-55 checksums, please format these addresses using their checksummed representation (e.g., using ethers.utils.getAddress or viem's getAddress).
1 participant
Summary
Validation
npm run test:render(9 passing)npm run render:deploymentnpm run codegennpm run buildnpm testis not runnable on Windows because Graph CLI 0.51.2 Matchstick does not support Windows. The repository CI runs that suite on Ubuntu.