Fix barPhase output and add Bars/2 division option#918
Open
caiomarinello wants to merge 3 commits intoDISTRHO:mainfrom
Open
Fix barPhase output and add Bars/2 division option#918caiomarinello wants to merge 3 commits intoDISTRHO:mainfrom
caiomarinello wants to merge 3 commits intoDISTRHO:mainfrom
Conversation
The previous barPhase formula was incorrect for Bars/4 and Bars/8 modes. Instead of sweeping smoothly from 0 to 10V across the full bar division, it would produce an inconsistent sawtooth that reset at different voltages each bar cycle. The fix normalizes the beat and sub-beat positions into a fractional bar count before applying fmod, producing a correct 0 10V phasor across the selected number of bars. Also adds a Bars/2 division option to complement the existing Bars/1, Bars/4 and Bars/8 options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous barPhase formula was incorrect for Bars/4 and Bars/8 modes. Instead of sweeping smoothly from 0 to 10V across the full bar division, it would produce an inconsistent sawtooth that reset at different voltages each bar cycle.
The fix normalizes the beat and sub-beat positions into a fractional bar count before applying fmod, producing a correct 0 10V phasor across the selected number of bars.
Also adds a Bars/2 division option to complement the existing Bars/1, Bars/4 and Bars/8 options.
Fixes #919