chore: implement task heartbeat#909
Merged
Merged
Conversation
chrisburr
reviewed
May 6, 2026
aldbr
reviewed
May 6, 2026
| result = await self.run_task(task_func, task_message) | ||
| finally: | ||
| if heartbeat_task is not None: | ||
| heartbeat_stop.set() |
Contributor
There was a problem hiding this comment.
IIUC, we assume it's fine to stop the heartbeat before calling _handle_failure/success and the rest until we ack.
What would happen if you stop the heartbeat and for some reason one of the remaining operations take too long and the task is given to another worker before ack is called?
Contributor
Author
There was a problem hiding this comment.
you would rather manage the heartbeat at the same level as the ack ?
Contributor
There was a problem hiding this comment.
Probably yes. Or at least a comment explaining why this can/can't happen.
What's your opinion?
(note: may be I just don't fully understand the concepts here though)
Contributor
Author
There was a problem hiding this comment.
What you say makes sense, I'll try to adapt it
Add a worker heartbeat so long-running tasks are not reclaimed by XAUTOCLAIM while they are still running. ReceivedMessage now carries both ack() and renew() callbacks, with renew implemented via XCLAIM to reset the pending idle timer for the current consumer. The worker starts this heartbeat for broker-delivered messages and stops it when execution finishes. Interactive execution is unchanged.
aldbr
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #908
renew Redis stream message ownership during worker execution
Add a worker heartbeat so long-running tasks are not reclaimed by
XAUTOCLAIM while they are still running. ReceivedMessage now carries
both ack() and renew() callbacks, with renew implemented via XCLAIM
to reset the pending idle timer for the current consumer. The worker
starts this heartbeat for broker-delivered messages and stops it when
execution finishes. Interactive execution is unchanged.