feat: conditionally set bankReleaseDate based on Olkypay balance#3525
Open
TaprootFreak wants to merge 4 commits intodevelopfrom
Open
feat: conditionally set bankReleaseDate based on Olkypay balance#3525TaprootFreak wants to merge 4 commits intodevelopfrom
TaprootFreak wants to merge 4 commits intodevelopfrom
Conversation
Only auto-release Olkypay bank transactions when the EUR balance is below 50,000. Above that threshold, manual release is required.
Check on every bank-tx cron cycle if the Olkypay EUR balance is below 50,000. If so, set bankReleaseDate on all unreleased Olkypay transactions.
- Fetch balance once in checkTransactions, pass to getOlkyTransactions - Replace loop with single bulk update for unreleased transactions - Extract magic number to OLKYPAY_RELEASE_BALANCE_LIMIT constant - Remove redundant releaseOlkypayTransactions method
davidleomay
approved these changes
Mar 30, 2026
❌ Security: 1 critical vulnerabilities |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bankReleaseDateon Olkypay transactions when the EUR balance is below 50,000bankReleaseDateremains unset, requiring manual release (AML check blocks processing until then)Test plan