Merged
Conversation
* feat: calculate spread-based fees for Scrypt exchange trades
Scrypt reports feeAmount=0 for all trades, but the real cost is hidden
in the price spread between execution price and market rate. This adds
automatic spread fee calculation using historical asset prices from the
AssetPrice table via getPriceAt().
After deploy, a one-time resync is needed for existing trades:
syncExchanges(new Date('2026-01-19'), ExchangeName.SCRYPT)
* fix: prettier formatting
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
* fix: update ICP payment URI to include canister ID
Change URI format from icp:{address}?amount={amount} to
icp:{canister-id}/transfer?to={principal}&amount={amount}
for both ICP native and all ICRC tokens.
* refactor: use Config for ICP native ledger canister ID instead of hardcoded constant
* feat: no forex fee for VCHF
---------
Co-authored-by: David May <david.leo.may@gmail.com>
davidleomay
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist