Merged
Conversation
* perf: cache payment deposit balances in finance log job The saveTradingLog cron job runs every minute but takes ~6 minutes due to blockchain RPC calls in getPaymentBalances() (10 chains, 24 assets). Cache the result in-memory and only refresh every 60 minutes, since payment deposit balances rarely change. * fix: preserve cached payment balances on refresh failure Only update the cache when fresh data is non-empty, so a failed blockchain RPC refresh does not overwrite valid cached values. * fix: revert cache guard, empty result on failure is correct behavior
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
Cache getCustomBalances() blockchain RPC results in-memory with a 60-minute TTL, same approach as payment deposit balance cache. Currently queries 3 Alchemy calls per run (1 chain, 3 addresses).
TaprootFreak
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist