Fix: quickfort UI freeze on large blueprints and strip undocumented ghost-features#1597
Open
sizzlins wants to merge 1 commit into
Open
Fix: quickfort UI freeze on large blueprints and strip undocumented ghost-features#1597sizzlins wants to merge 1 commit into
sizzlins wants to merge 1 commit into
Conversation
Member
|
This PR seems to combine two unrelated changes, one related to quickfort and one implementing some sort of manual-save feature, possibly the same as the one in #1583. Please don't bundle unrelated changes into a single PR. |
292b40a to
e6ab51d
Compare
e6ab51d to
ad9eac2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
Fix: quickfort UI freeze on massive blueprints and strip undocumented ghost-featuresThis PR addresses severe UI lag when selecting massive blueprints (e.g.
industry2) in thegui/quickfortoverlay, and removes broken, undocumented ghost-code from the corequickfort.luaparser.Fixed massive UI render lag
onRenderFramewas synchronously re-parsing the blueprint CSV and reevaluating thousands of matrix tiles 60 times a second whenever the mouse moved. This completely froze the game engine.dx, dy, dz) to the cached preview tiles. The blueprint now perfectly tracks the mouse at a smooth 60 FPS while the heavy collision math runs asynchronously in the background.Removed
argparse.stringListThe
actionargument was previously being run throughargparse.stringList(action). This undocumented feature bypassed the safety mechanism (not dfhack.isMapLoaded()) because the literalactionstring check (action == 'run') fails if the string is"run,orders".Removed
reduce_transform()The UI had a 25-line mathematical
reduce_transform()block dedicated purely to minimizing the length of a UI display text label when a user hit the rotate hotkey multiple times.Deleted the function to simplify the UI loop.
transformationsnow behaves as a standard array.Updated
SELECT_ALLtoSEC_SELECTas the 51.01 transition has been stable for multiple major releases.