Skip to content

Removed call which is in core libs utilities #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sukhybhullar-nimble wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −26
Open

Removed call which is in core libs utilities #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions src/Dfe.CaseAggregationService.Application/Common/Extensions/EnumExtensions.cs
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions src/Dfe.CaseAggregationService.Application/Dfe.CaseAggregationService.Application.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<PackageReference Include="GovUK.Dfe.CoreLibs.Caching" Version="1.0.10" />
<PackageReference Include="FluentValidation" Version="11.10.0" />
<PackageReference Include="FluentValidation.AspNetCore" Version="11.3.0" />
<PackageReference Include="GovUK.Dfe.CoreLibs.Utilities" Version="1.0.16" />
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="8.0.18" />
<PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.2" />
Expand Down
6 changes: 3 additions & 3 deletions ...fe.CaseAggregationService.Application/Services/Builders/GetCaseInfoFromCompleteSummary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using Dfe.CaseAggregationService.Application.Common.Extensions;
using Dfe.CaseAggregationService.Application.Services.Builders.Dfe.CaseAggregationService.Application.Services.Builders;
using Dfe.CaseAggregationService.Application.Services.Builders.Dfe.CaseAggregationService.Application.Services.Builders;
using Dfe.CaseAggregationService.Application.Common.Models;
using Dfe.CaseAggregationService.Domain.Entities.Complete;
using GovUK.Dfe.CoreLibs.Utilities.Extensions;

namespace Dfe.CaseAggregationService.Application.Services.Builders
{
Expand All @@ -10,9 +10,8 @@
private const string System = "Complete conversions, transfers and changes";
public UserCaseInfo GetCaseInfo(CompleteSummary summary)
{

return new UserCaseInfo(GetTitle(summary),
getSystemLinks.GetCompleteTitleLink(summary.ProjectId.Value.ToString()),

Check warning on line 14 in src/Dfe.CaseAggregationService.Application/Services/Builders/GetCaseInfoFromCompleteSummary.cs

View workflow job for this annotation

GitHub Actions / Build, Test and Analyse 

Nullable value type may be null.
System,
summary.CaseType.ToDescription(),
summary.CreatedDate ?? DateTime.MinValue,
Expand All @@ -30,6 +29,7 @@
return getGuidanceLinks.GenerateLinkItems("CompleteConversion");
return [];
}

private IEnumerable<LinkItem> GenerateResourceLinkItems(CompleteSummary summary)
{

Expand All @@ -40,7 +40,7 @@
return [];
}

private string GetTitle(CompleteSummary summary)

Check warning on line 43 in src/Dfe.CaseAggregationService.Application/Services/Builders/GetCaseInfoFromCompleteSummary.cs

View workflow job for this annotation

GitHub Actions / Build, Test and Analyse 

Make 'GetTitle' a static method. (https://rules.sonarsource.com/csharp/RSPEC-2325)
{
return summary.AcademyName;
}
Expand Down
Loading