Skip to content

Address PR review: custom typeRegistry test, CI Flutter version pin, example pubspec material design flag#28

Merged
RZEROSTERN merged 2 commits intochore/publication-readinessfrom
copilot/sub-pr-27
Mar 25, 2026
Merged

Address PR review: custom typeRegistry test, CI Flutter version pin, example pubspec material design flag#28
RZEROSTERN merged 2 commits intochore/publication-readinessfrom
copilot/sub-pr-27

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 25, 2026

Three issues flagged in review on the publication-readiness PR:

  • typeRegistry test was a no-op — the test claimed to verify EditorController.fromJson respects a custom typeRegistry but called it with the default registry. Replaced with a test that registers a _PrefixedHeaderMapper and asserts the custom-mapped text appears in the parsed block:
final customRegistry = BlockTypeRegistry()
  ..register(_PrefixedHeaderMapper('Custom: '));

final ctrl = EditorController.fromJson(json, typeRegistry: customRegistry);
expect((ctrl.blocks.first as HeaderBlock).text, 'Custom: Hi');
  • CI Flutter version unpinnedsubosito/flutter-action was set to channel: stable only, which can drift from the repo-pinned version. Added flutter-version: '3.41.5' to match .fvmrc.

  • example/pubspec.yaml missing uses-material-design: true — the example app uses MaterialApp and Icons.* but the pubspec lacked the flutter: section required to bundle the Material Icons font. Added it.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…pubspec flutter section

Co-authored-by: RZEROSTERN <3065243+RZEROSTERN@users.noreply.github.com>
Agent-Logs-Url: https://github.com/RZEROSTERN/editorjs-flutter/sessions/913476ea-4c30-4220-b059-270bfa4fcc70
Copilot AI changed the title [WIP] Chore for CI/CD, code coverage and example app Address PR review: custom typeRegistry test, CI Flutter version pin, example pubspec material design flag Mar 25, 2026
Copilot AI requested a review from RZEROSTERN March 25, 2026 21:20
@RZEROSTERN RZEROSTERN marked this pull request as ready for review March 25, 2026 21:54
@RZEROSTERN RZEROSTERN merged commit 22fb72a into chore/publication-readiness Mar 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants