Skip to content

Bug/optional geospatial component submit data#434

Merged
davidjamesstone merged 4 commits into
mainfrom
bug/optional-geospatial-component-submit-data
Jun 24, 2026
Merged

Bug/optional geospatial component submit data#434
davidjamesstone merged 4 commits into
mainfrom
bug/optional-geospatial-component-submit-data

Conversation

@davidjamesstone

@davidjamesstone davidjamesstone commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Proposed change

While doing the ticket I noticed there was a bug that caused the submission to fail when sending optional Geospatial fields where the user hadn't added any features. The submit sent the value as undefined which caused a schema validation failure given it expects a string. This PR replaces undefined with an empty string which aligns with what FileUpload sends when optional.

Jira ticket: https://eaflood.atlassian.net/browse/DF-1157

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Misc. (documentation, build updates, etc)

Checklist

  • You have executed this code locally and it performs as expected.
  • [] You have added tests to verify your code works.
  • You have added code comments and JSDoc, where appropriate.
  • There is no commented-out code.
  • You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
  • The tests are passing (npm run test).
  • The linting checks are passing (npm run lint).
  • The code has been formatted (npm run format).

@davidjamesstone davidjamesstone marked this pull request as ready for review June 24, 2026 13:20

@jbarnsley10 jbarnsley10 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding a test in case future code breaks it? Approving anyway

@davidjamesstone

Copy link
Copy Markdown
Contributor Author

Worth adding a test in case future code breaks it? Approving anyway

Resolved with d911ad5

@sonarqubecloud

Copy link
Copy Markdown

@davidjamesstone davidjamesstone merged commit f615257 into main Jun 24, 2026
23 checks passed
@davidjamesstone davidjamesstone deleted the bug/optional-geospatial-component-submit-data branch June 24, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants