FSR-1564 | Stop duplicate rainfall totals being inserted#145
Open
LeeGordon83 wants to merge 4 commits intodevelopmentfrom
Open
FSR-1564 | Stop duplicate rainfall totals being inserted#145LeeGordon83 wants to merge 4 commits intodevelopmentfrom
LeeGordon83 wants to merge 4 commits intodevelopmentfrom
Conversation
…uctions to readme to setup local rloi debug, added test script, data, and debug setup
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To summarise:
Added an ON CONFLICT ... DO NOTHING clause to the INSERT INTO sls_telemetry_value_parent SQL query.
The conflict target is (station, region, COALESCE(qualifier, ''), start_timestamp, end_timestamp) scoped specifically to rainfall records
Added a guard after the parent insert in rloi.js : if res.rows[0] is falsy (i.e. the DO NOTHING path was taken and nothing was returned), the processing of child values for that parent is skipped entirely (increments processed counter and returns early).
Added further assertions to existing unit test to cover above
Updated readme.txt to instruct how to run floi test locally. I have included everything needed to test this locally including duplicate test data, test script, and local debug setup. This will be useful for testing but can maybe be removed at a later date.
Forced to refactor rloi.js as Sonar complained about complexity.