-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/ni 161 - Meteoalarm message post #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
449b15f
Including wiremock for test double
teddmason 6f3b45e
Adding meteoalarm post to processMessage along with a couple of edits…
teddmason 3774e05
sorting magic numbers for sonar
teddmason 413552a
addressing sonar issue for node.remove()
teddmason 87aaa86
package updates
teddmason 6b04a64
Updating the processMessage so that a failed meteoalarm post fails th…
teddmason ea35728
review feedback, making NODE_TLS_REJECT_UNAUTHORIZED=0 in dev environ…
teddmason af1374a
package update
teddmason 56d677c
Adding in toggle variable for meteoalarm integration
teddmason 805facc
switching negated condition around to please Wadders and Sonar
teddmason 345ce00
NI-60: Adding in additional logging, based from NI-161 (#78)
teddmason cf404b0
adding in a log for meteoalarm authentication success
teddmason 30f55af
Removing square brackets from v2 message text
teddmason fea4158
Removing new line after You should: and you can: in instruction field
teddmason 6d368fb
Logic to exclude alert areas from meteoalarm post
teddmason dfa14c1
refactoring if statement for sonarcloud
teddmason File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "mappings": [ | ||
| { | ||
| "request": { | ||
| "method": "POST", | ||
| "urlPath": "/warnings" | ||
| }, | ||
| "response": { | ||
| "status": 201, | ||
| "body": "{\"warning\": {\"uuid\": \"{{randomValue type='UUID'}}\" } }" | ||
| } | ||
| }, | ||
| { | ||
| "request": { | ||
| "method": "POST", | ||
| "urlPath": "/tokens" | ||
| }, | ||
| "response": { | ||
| "status": 200, | ||
| "body": "{\"tokenType\": \"Bearer\", \"token\": \"{{randomValue length=64 type='ALPHANUMERIC'}}\", \"expiresIn\": \"300\" }" | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should [getMessage] be replaced with [fetchMessageBody] so log entries reflect the correct function name? As fetchMessageBody is an internal function called from the getMessage function I'm happy with either approach and will approve the pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prefix was just meant to match the overarching lambda function that was invoked