UI: turn the editor into a sequential optical layout table#496
Open
dragonleopardpig wants to merge 7 commits intoDCC-Lab:masterfrom
Open
UI: turn the editor into a sequential optical layout table#496dragonleopardpig wants to merge 7 commits intoDCC-Lab:masterfrom
dragonleopardpig wants to merge 7 commits intoDCC-Lab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the UI editor for sequential optical layouts and fixes several issues in the
Object = Infinityworkflow.Main changes
ObjectImage0−∞Result
For infinity-object setups, the display now follows a physically consistent axis model:
0−∞Notes
This PR also removes stale display-offset behavior that caused incorrect plotting and runtime errors while editing.
Suggested update comment on the PR:
Updated this PR substantially on the same branch.
The current version focuses on fixing the infinity-object workflow in the editor: the first lens stays at physical position
0, the object is shown on the object-side tick labeled−∞, and the image plane handling now stays aligned with the table state.