file extensions in Save() and Load() methods are optional#728
file extensions in Save() and Load() methods are optional#728manuschneider merged 4 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
==========================================
+ Coverage 35.44% 35.47% +0.02%
==========================================
Files 215 214 -1
Lines 33071 33007 -64
Branches 13170 13130 -40
==========================================
- Hits 11723 11709 -14
+ Misses 19424 19376 -48
+ Partials 1924 1922 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IvanaGyro
left a comment
There was a problem hiding this comment.
I suggest deprecate the feature that automatically adds file extension while saving and keep the function for loading unchanged. Automatically appending file extension while saving and loading files is uncommon practice.
Additionally, can you squash the two commits in this PR?
I thought it might actually be handy to just provide the base name and cytnx will add the common extension for this type of object. We can have a separate issue on deprecating this, but this might affect basically all unit tests.
How do I best squash them with git? |
Using |
if no file extension is given, the standard extension for the corresponding object type is added to the filename this is backwards compatible with the previous behavior but allows to use custom file extensions and call Save() and Load() with the exact same arguments
9ddb7bb to
91dd9ac
Compare
added file endings to all filenames when Save is used corrected include order
Fixes #727.
If no file extension is given, the standard extension for the corresponding object type is added to the filename.
This is backwards compatible with the previous behavior but allows to use custom file extensions and call Save() and Load() with the exact same arguments.