MacOS quit was sometimes left hanging for a while + save screenshot handler#56
Open
skymen wants to merge 3 commits intoCynToolkit:developfrom
Open
MacOS quit was sometimes left hanging for a while + save screenshot handler#56skymen wants to merge 3 commits intoCynToolkit:developfrom
skymen wants to merge 3 commits intoCynToolkit:developfrom
Conversation
Member
|
Seems fine |
skymen
changed the title
Author
|
Added a new screenshot handler that I need |
…ng the file otherwise steam fails to copy it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am fixing an issue with mac os where trying to close or quit the app using the OS close/quit buttons would just not do anything.
Apparently this could be due to the socket server keeping it open, so I am trying this fix where the app cleans up its server on quit. So far it seems to work but I will need to double check I didnt break anything on other OSes