Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Fixes
Added support to pass
--runnergroupflag toconfig.shwhen installing the runner software. The flag is configured using a terraform variablegithub_runner_groupand the default values is "".Added support to configure the runner VM
max_run_durationusing a terraform variablegithub_runners_max_run_duration. The value is specified in seconds. The default is(86400 * 5) + 300Renamed the runners from
runner-{instance_uuid}togcp-runner-{instance_uuid}. This allows runners to be more easily identified in github for maintenance. Also, and perhaps more importantly,_handle_completed_jobwill now be able to identify and shut down VMs for gcp runners and not unrelated runners.webhook_service.py_handle_completed_job: Only shutdown VMs from runners whose name starts withgcp-runner-The VM startup_script will now
cdinto therunner-actionsfolder before executingrun.sh. This solvesldd: ./bin/libcoreclr.so: No such file or directoryand two otherNo such file or directoryerrors. Changing directories into therunner-actionsfolder is the formal procedure when installing the runner software.