Gracefully handle missing signing secrets in Android workflow#4
Gracefully handle missing signing secrets in Android workflow#4Cross2pro wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Validate signing secrets | ||
| id: signing | ||
| run: | | ||
| missing=() | ||
| for var in ANDROID_KEYSTORE_BASE64 ANDROID_KEYSTORE_PASSWORD ANDROID_KEY_ALIAS ANDROID_KEY_PASSWORD; do | ||
| if [ -z "${!var}" ]; then | ||
| missing+=("$var") | ||
| fi | ||
| done | ||
|
|
||
| if [ ${#missing[@]} -gt 0 ]; then | ||
| echo "Signing secrets are not fully configured: ${missing[*]}" >&2 | ||
| echo "signing_ready=false" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "signing_ready=true" >> "$GITHUB_OUTPUT" | ||
| fi | ||
|
|
||
| - name: Skip signed build (missing secrets) | ||
| if: steps.signing.outputs.signing_ready != 'true' | ||
| run: echo 'Skipping signed release build because required signing secrets are not configured.' |
There was a problem hiding this comment.
The new guard step sets signing_ready=false and the next step just echoes a message when any signing secret is missing, after which the job ends without uploading an artifact or failing. This is reasonable for pull-request builds where secrets are intentionally unavailable, but it also fires for tag pushes. A release tag without configured secrets will now report a green build even though no APK is produced or published, which can mislead automation that relies on a failing status to detect misconfigured releases. Consider failing the job (or at least the tag-push path) when secrets are missing so that release publishers are notified.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
Codex Task