Fix IPv6 hostname resolution and literal handling in API URLs#51
Open
jdomenechg wants to merge 1 commit intoCpuID:masterfrom
Open
Fix IPv6 hostname resolution and literal handling in API URLs#51jdomenechg wants to merge 1 commit intoCpuID:masterfrom
jdomenechg wants to merge 1 commit intoCpuID:masterfrom
Conversation
Collaborator
|
Thanks @jdomenechg - will work to bundle this in with other tweaks here in the next update! @CpuID @danhunsaker - forking this out (as well) from PVEWHMCS to improve the client. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes IPv6-related issues in the Proxmox PHP API client:
[ipv6]).These changes prevent connection failures when using IPv6-only or IPv6-literal Proxmox endpoints.
Tested against Proxmox VE with IPv6 endpoints.