Add getTicket() function. Add $verbose_mode (default: false).#42
Add getTicket() function. Add $verbose_mode (default: false).#42lsthompson wants to merge 8 commits intoCpuID:masterfrom
Conversation
Helps as the class gets added to code-bases, easier to track it
danhunsaker
left a comment
There was a problem hiding this comment.
Looks good overall, but it might be nice to make a couple tweaks. See my other comments for details on what I mean.
Thanks for the review @danhunsaker - how's the updated pull looking now? Appreciate your pointers on all fronts. I'd like to switch back the reverted-to-error-log section? I'm a fan of passing back the specifics if it's doable. |
|
@danhunsaker @CpuID could you please test? It's been 2 years now, be nice to merge it in. :) |
|
See #12 (review) re next steps. Let's get that PR sorted first, then move to this one. Also someone needs to sort out the conflicts at the same time, I don't have the free cycles atm to do so. Probably best to sort the other PR conflicts first then once master is clean, sort them here also. |
Helps as the class gets added to code-bases, easier to track it. You weren't wrong about not working with it!
Investigate @danhunsaker concept of PSR-3 handling mentioned in Issue #19 back in 2015.
https://www.php-fig.org/psr/psr-3/