feat(gradebook): restrict gradebook access to owners and managers and harden authz specs#8461
Closed
LWS49 wants to merge 1 commit into
Closed
feat(gradebook): restrict gradebook access to owners and managers and harden authz specs#8461LWS49 wants to merge 1 commit into
LWS49 wants to merge 1 commit into
Conversation
… harden authz specs
Collaborator
Author
|
Superseded by #8466 (renamed to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restricts gradebook access to course owners and managers and hardens the authorization specs. The gradebook ability component now grants gradebook access (view, manage, external CRUD, import, reorder) only to owner/manager roles; the controller and ability specs assert the allowed and forbidden roles.
Regression prevention
Covers: gradebook ability for owner/manager vs other roles, and gradebook/external-assessments controller authorization (ability spec + the two controller specs). No data or schema change. Specs run on push/CI.