chore(deps): override brace-expansion and js-yaml - #145
Closed
ar2rsawseen wants to merge 1 commit into
Closed
Conversation
Both advisories reach this repo only through devDependencies, so nothing that ships to SDK consumers is affected: - brace-expansion, GHSA-3jxr-9vmj-r5cp: 1.1.12 at the top level and 2.0.2 under mocha. - js-yaml, GHSA-52cp-r559-cp3m: 3.14.1 at the top level (via eslint) and 4.1.0 under mocha. Each advisory patches its majors separately, so both packages get one range-keyed override per major and no major is forced across a boundary. Lockfile changes are limited to these two packages. Verified with npm ci, eslint (the pretest step, which consumes both packages) and the mocha suite: 94 passing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Cookiezaurs
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both advisories reach this repo only through
devDependencies, so nothing that ships to SDK consumers is affected.overridesin a published package's manifest applies to this repo's own installs, not to downstream projects.brace-expansionmocha)^1.1.16,^2.1.2js-yamleslint), 4.1.0 (undermocha)^3.15.0,^4.3.0Each advisory patches its major lines separately, so both packages get one range-keyed override per major rather than forcing a single version across a major boundary.
Resolution
Lockfile changes are confined to these two packages; no other version moved:
brace-expansion1.1.12 → 1.1.18, and 2.0.2 → 2.1.4 undermochajs-yaml3.14.1 → 3.15.1, and 4.1.0 → 4.3.1 undermochaBoth files keep their existing CRLF line endings, so the diff is only the changed entries.
Verification
npm cisucceeds (449 packages).eslint --ignore-path .eslintignore .— thepreteststep, which consumes both packages — passes clean.Targets
staging, matching how this repo takes changes.🤖 Generated with Claude Code