Adding features to the HDF file generation scripts#267
Open
eirikgje wants to merge 5 commits into
Open
Conversation
| return int(np.ceil(self.nchunks[band] / NUM_FITS_FILES_PER_SEGMENT)) | ||
|
|
||
| def get_version(self): | ||
| return 2 |
Collaborator
There was a problem hiding this comment.
Should this be updated to version 3 now or are these small enough changes to not need to do that?
RaelynSullivan
approved these changes
May 28, 2026
Collaborator
RaelynSullivan
left a comment
RaelynSullivan
left a comment
There was a problem hiding this comment.
Looks pretty good, I think it is ok to merge. Some of the functions (not modified by you but just functions that exist in this file) are still missing doc strings, those can be nice.
Only comments would be maybe the get_version needs to be updated to return 3? Not sure if this is enough for a whole new version, but could return 2.1 or something as well if it is a minor update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added features include: