Changed name of ephemeris_flagging to ephemeris_tools, to accomodate …#266
Open
nostutzer wants to merge 1 commit into
Open
Changed name of ephemeris_flagging to ephemeris_tools, to accomodate …#266nostutzer wants to merge 1 commit into
nostutzer wants to merge 1 commit into
Conversation
…future generalized tools in the name. Also added functionality to represent sky coordinates in a observatory centric coordinate frames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
ephemeris_flagging.py->ephemeris_tools.py, so accommodate future tools that are not just flagging. The name of theEphemerisFlaggerclass name was changed toEphemerisTools. Similar change for the corresponding test functions.CustomFramecoordinate frame class that can represent sky coordinates relative to some observatory position. It is defined to be parallel to the ICRS, but the origin is translated to the observatory position.get_observaroty_ephemeris_pointingmethod toEphemerisToolsclass that computes the apparent coordinates of some celestial body defined by a ephemeris file, as seen from the provided observatory.Wrote a test function to assert if the
CustomFramebehaves and transforms as expected. All tests passed prior to committing.