Conversation
This reverts commit 4f6c64a.
Precond -- one conflict in line_comp_mod to be resolved
… the file validation for monopole priors
dncnwtts
reviewed
Jan 22, 2026
dncnwtts
reviewed
Jan 22, 2026
| @@ -1045,6 +1094,18 @@ subroutine read_star_catalogue(self, cpar, id, id_abs) | |||
| !load in the beam information | |||
| call init_beam_templates(self, cpar, id, id_abs) | |||
|
|
|||
| ! Update mixing matrix -- HKE: GAIN IS MISSING | |||
Collaborator
There was a problem hiding this comment.
Another thing that could be deleted
dncnwtts
reviewed
Jan 22, 2026
| write(58,*) | ||
| do i = 1, size(s_tot,1) | ||
| write(58,*) i, tod_arr(i, 1) | ||
| open(58,file='gain_delta_'//itext//'.dat', recl=1024) |
Collaborator
There was a problem hiding this comment.
This really should be deleted, since it will save a file to the write directory
dncnwtts
reviewed
Jan 22, 2026
| end do | ||
|
|
Collaborator
There was a problem hiding this comment.
Another thing we need to delete
dncnwtts
reviewed
Jan 22, 2026
| binmap%A_map(off+3,pix_) = binmap%A_map(off+3,pix_) + tod%sin2psi(psi_) * inv_sigmasq | ||
| end if | ||
|
|
||
| ! if(pix_ == 1 .and. det==2) then |
Collaborator
There was a problem hiding this comment.
Do we need this kind of comment still?
dncnwtts
reviewed
Jan 22, 2026
| ncut = 0 | ||
| if (output_scan == self%scanid(scan)) open(58, file='flag_stage2.dat') | ||
| do iter = 1, 1 | ||
| !!$ ! Compute full-scan, masked rms0 |
Collaborator
There was a problem hiding this comment.
Another set of comments to remove
dncnwtts
reviewed
Jan 22, 2026
Collaborator
dncnwtts
left a comment
dncnwtts
left a comment
There was a problem hiding this comment.
Mostly looks good. Some comments could be removed (see what I wrote before)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushing the version of the code that ran DR2.1 to master