fix: char-aware truncation to prevent UTF-8 boundary panics#573
Open
sungdark wants to merge 1 commit intoCortexLM:masterfrom
Open
fix: char-aware truncation to prevent UTF-8 boundary panics#573sungdark wants to merge 1 commit intoCortexLM:masterfrom
sungdark wants to merge 1 commit intoCortexLM:masterfrom
Conversation
Fixes 3 byte-boundary panics in agent_cmd handlers when agent descriptions/prompts contain multi-byte UTF-8 characters (emojis, international text) near truncation boundaries. - list.rs: use chars().take(35) instead of byte slice [..35] - show.rs: use chars().take(500) instead of byte slice [..500] - generate.rs: use chars().take(500) instead of byte slice [..500] These panics crashed the entire CLI when users had emojis or non-ASCII characters in their agent descriptions/prompts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 3 byte-boundary panics in agent_cmd handlers when agent descriptions or prompts contain multi-byte UTF-8 characters (emojis, international text) near truncation boundaries.
Changes
Root Cause
Byte-based slicing
&s[..n]panics when the byte indexnlands inside a multi-byte UTF-8 character.Fix
Replaced byte-based slicing with
chars().take(n).collect::<String>()for safe character-aware truncation.&d[..35]+d.len() > 38&prompt[..500]+prompt.len() > 500&generated.system_prompt[..500]Testing
Verified with
cargo check(builds successfully).Related
Addresses Issue #3920 in PlatformNetwork/bounty-challenge.