added simple counter test

[dahliamalkhi]

This change is

[no2chem]

bin/airline, line 0 [r1] (raw file):
Why was this file deleted? I guess if you want another example, you should create a new file "counter" and symlink it to run_example. run_example.sh should probably check $0 and call the correct class.

---

Comments from Reviewable

[no2chem]

Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions.

---

src/main/java/org/corfudb/example/org/corfudb/example/counter/SimpleCounterExample.java, line 35 [r1] (raw file):

    }

    public static class SharedCounter implements ICorfuSMRObject {

You actually shouldn't need to implement ICorfuSMRObject.

---

src/main/java/org/corfudb/example/org/corfudb/example/counter/SimpleCounterExample.java, line 64 [r1] (raw file):

        SharedCounter cnt = simpleCounterExample.getSharedCounter();
        cnt.setCnt(44);
        assert cnt.getCnt() == 44;

An assertion is a bit strange here. Shouldn't you print the values out? Otherwise the person running the test won't see anything.

---

src/test/java/org/corfudb/example/counter/SimpleCounterTest.java, line 49 [r1] (raw file):

        SimpleCounterExample.SharedCounter cnt = simpleCounter.getSharedCounter();
        cnt.setCnt(44);
        assert cnt.getCnt() == 44;

You should use the assertJ package (assertThat()), used throughout the rest of Corfu instead of the Java assert statement.

---

Comments from Reviewable

[dahliamalkhi]

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

---

src/main/java/org/corfudb/example/org/corfudb/example/counter/SimpleCounterExample.java, line 35 [r1] (raw file):

Previously, no2chem (Michael Wei) wrote…

You actually shouldn't need to implement ICorfuSMRObject.

OK, removing. However, the airline example does this .. I copied from it.

---

src/main/java/org/corfudb/example/org/corfudb/example/counter/SimpleCounterExample.java, line 64 [r1] (raw file):

Previously, no2chem (Michael Wei) wrote…

An assertion is a bit strange here. Shouldn't you print the values out? Otherwise the person running the test won't see anything.

sure, ok.

---

src/test/java/org/corfudb/example/counter/SimpleCounterTest.java, line 49 [r1] (raw file):

Previously, no2chem (Michael Wei) wrote…

You should use the assertJ package (assertThat()), used throughout the rest of Corfu instead of the Java assert statement.

done

---

bin/airline, line [r1] (raw file):

Previously, no2chem (Michael Wei) wrote…

Why was this file deleted? I guess if you want another example, you should create a new file "counter" and symlink it to run_example. run_example.sh should probably check $0 and call the correct class.

looks like another artifact of git problem syncying bin directory. I'll revert this change.

---

Comments from Reviewable