Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions MCPForUnity/Editor/Tools/GameObjects/GameObjectDelete.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,7 @@ internal static object Handle(JToken targetToken, string searchMethod)
{
string goName = targetGo.name;
int goId = targetGo.GetInstanceIDCompat();
// Note: Undo.DestroyObjectImmediate doesn't work reliably in test context,
// so we use Object.DestroyImmediate. This means delete isn't undoable.
// TODO: Investigate Undo.DestroyObjectImmediate behavior in Unity 2022+
Object.DestroyImmediate(targetGo);
Undo.DestroyObjectImmediate(targetGo);
deletedObjects.Add(new { name = goName, instanceID = goId });
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using System.Collections.Generic;
using NUnit.Framework;
using UnityEditor;
using UnityEngine;
using Newtonsoft.Json.Linq;
using MCPForUnity.Editor.Tools.GameObjects;
Expand Down Expand Up @@ -375,6 +376,35 @@ public void Delete_MultipleObjectsSameName_DeletesCorrectly()
}

#endregion

#region Undo Tests

[Test]
public void Delete_RegistersUndo_RestoresOnUndo()
{
var target = CreateTestObject("UndoRoundtrip");

var p = new JObject
{
["action"] = "delete",
["target"] = "UndoRoundtrip",
["searchMethod"] = "by_name"
};

var result = ManageGameObject.HandleCommand(p);
var resultObj = result as JObject ?? JObject.FromObject(result);
Assert.IsTrue(resultObj.Value<bool>("success"), resultObj.ToString());
Assert.IsNull(GameObject.Find("UndoRoundtrip"), "Object should be deleted before undo");
testObjects.Remove(target);

Undo.PerformUndo();

var restored = GameObject.Find("UndoRoundtrip");
Assert.IsNotNull(restored, "Undo should restore deleted GameObject");
testObjects.Add(restored);
}

#endregion
}
}