Skip to content

feat: configurable macOS terminal app via EditorPrefs #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skyhills13 wants to merge 1 commit into
base: beta
Choose a base branch
from
Open

feat: configurable macOS terminal app via EditorPrefs #1117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MCPForUnity/Editor/Constants/EditorPrefKeys.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,7 @@ internal static class EditorPrefKeys
internal const string LogRecordEnabled = "MCPForUnity.LogRecordEnabled";

internal const string ExecuteCodeCompiler = "MCPForUnity.ExecuteCode.Compiler";

internal const string MacOSTerminalApp = "MCPForUnity.MacOSTerminalApp";
}
}
6 changes: 5 additions & 1 deletion MCPForUnity/Editor/Services/Server/TerminalLauncher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
using System;
using System.IO;
using MCPForUnity.Editor.Constants;
using MCPForUnity.Editor.Helpers;
using UnityEditor;
using UnityEngine;

namespace MCPForUnity.Editor.Services.Server
Expand Down Expand Up @@ -45,10 +47,12 @@ public System.Diagnostics.ProcessStartInfo CreateTerminalProcessStartInfo(string
"clear\n" +
$"{command}\n");
ExecPath.TryRun("/bin/chmod", $"+x \"{scriptPath}\"", Application.dataPath, out _, out _, 3000);
string terminalApp = EditorPrefs.GetString(EditorPrefKeys.MacOSTerminalApp, "Terminal");
if (string.IsNullOrWhiteSpace(terminalApp)) terminalApp = "Terminal";
return new System.Diagnostics.ProcessStartInfo
{
FileName = "/usr/bin/open",
Arguments = $"-a Terminal \"{scriptPath}\"",
Arguments = $"-a \"{terminalApp}\" \"{scriptPath}\"",
Comment on lines +50 to +55
Comment on lines +50 to +55
UseShellExecute = false,
CreateNoWindow = true
};
Expand Down
1 change: 1 addition & 0 deletions MCPForUnity/Editor/Windows/EditorPrefs/EditorPrefsWindow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ public class EditorPrefsWindow : EditorWindow
{ EditorPrefKeys.LastLocalHttpServerPidArgsHash, EditorPrefType.String },
{ EditorPrefKeys.LastLocalHttpServerPidFilePath, EditorPrefType.String },
{ EditorPrefKeys.LastLocalHttpServerInstanceToken, EditorPrefType.String },
{ EditorPrefKeys.MacOSTerminalApp, EditorPrefType.String },
};

// Templates
Expand Down