fix: correct /v1/images/edits path + add Ollama /api/embed alias#242
Merged
Conversation
The OpenAI image edit endpoint is /v1/images/edits (plural), but PR #222 (shipped in v1.25.0) registered the route as /v1/images/edit (singular). Real OpenAI SDK clients hit a 404 against aimock. Updates the canonical path constant in server.ts, the OpenAI-compat suffix list, the in-source comments and default fallbacks in images.ts, the test suite (renamed image-edit.test.ts -> image-edits.test.ts and hits the new path; one assertion confirms the legacy singular path is now 404), the DRIFT.md route table, the competitive-matrix keywords, and the README multimedia summary. Closes #221
commit: |
Bumps package.json from 1.27.2 to 1.27.3 (patch), updates the .claude-plugin manifests, and records the #221 fix plus the Ollama /api/embed alias under [1.27.3] in CHANGELOG.md.
jpr5
force-pushed
the
fix/images-edits-route
branch
from
b9952fe to
0a63e64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two route-registration bug fixes shipped as patch v1.27.3.
/v1/images/edits— corrects the OpenAI image-edit endpoint path. v1.25.0 registered it at/v1/images/edit(singular), but OpenAI's actual endpoint is/v1/images/edits(plural). Real OpenAI SDKs were hitting aimock with 404. Closes Support for /images/edit #221./api/embed— adds the current Ollama embeddings endpoint as a co-registered alias for the legacy/api/embeddings. Both paths now dispatch to the same handler. Per https://github.com/ollama/ollama/blob/main/docs/api.md,/api/embedis the current documented path;/api/embeddingsis retained for back-compat. Modern Ollama SDKs targeting/api/embedno longer 404.Also updates README/DRIFT.md to reflect both corrections, and bumps v1.27.2 → v1.27.3 across
package.json,.claude-plugin/plugin.json,.claude-plugin/marketplace.json, andCHANGELOG.md.Test plan
/v1/images/editsreturns 200 and/v1/images/editreturns 404/api/embedreturns the same 1536-dim Ollama embedding shape as/api/embeddings