Open
Conversation
…-native-vector-icons/fonts.gradle'
c47eaa8 to
2300f31
Compare
|
Static Code Review 📊 ✅ All quality checks passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary by Typo
Overview
This PR addresses a bug where
Bufferobjects with a non-zerobyteOffsetwere not correctly handled when passed to native bridge functions, leading to incorrect cryptographic computations. The fix involves introducing a utility to ensure properArrayBufferconversion for allBufferinstances.Key Changes
toArrayBufferutility function to correctly convertBufferobjects, especially those with abyteOffset, intoArrayBufferfor native calls.DiffieHellmanandECDHclasses to usetoArrayBufferfor all native bridge interactions involving buffers (e.g.,init,computeSecret,setPublicKey,setPrivateKey).ecdh_tests.tsto specifically verify thatcomputeSecretworks as expected when provided with a sliced public key buffer.Work Breakdown
To turn off PR summary, please visit Notification settings.