Skip to content

Move color service to core/ui #3716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shroffk merged 7 commits into from
Mar 30, 2026

Merge branch 'master' into refactor-colors

55da4bb
Select commit
Loading
Failed to load commit list.
Merged

Move color service to core/ui #3716

Merge branch 'master' into refactor-colors
55da4bb
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 24, 2026 in 1m 40s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 28 in core/util/src/main/java/org/phoebus/util/config/ConfigFileParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZdPH6Y8hnMHh5W&open=AZyeowZdPH6Y8hnMHh5W&pullRequest=3716

Check warning on line 159 in core/ui/src/main/java/org/phoebus/ui/color/NamedWidgetColors.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowWsPH6Y8hnMHh5M&open=AZyeowWsPH6Y8hnMHh5M&pullRequest=3716

Check warning on line 111 in core/ui/src/test/java/org/phoebus/ui/color/ColorUnitTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZlPH6Y8hnMHh5Z&open=AZyeowZlPH6Y8hnMHh5Z&pullRequest=3716

Check warning on line 66 in core/ui/src/main/java/org/phoebus/ui/color/WidgetColorService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Lambda should be used to defer string concatenation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZFPH6Y8hnMHh5R&open=AZyeowZFPH6Y8hnMHh5R&pullRequest=3716

Check warning on line 30 in core/ui/src/main/java/org/phoebus/ui/color/WidgetColorService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a private constructor to hide the implicit public one. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZFPH6Y8hnMHh5P&open=AZyeowZFPH6Y8hnMHh5P&pullRequest=3716

Check warning on line 24 in core/util/src/main/java/org/phoebus/util/config/FileToStreamFunction.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZNPH6Y8hnMHh5T&open=AZyeowZNPH6Y8hnMHh5T&pullRequest=3716

Check warning on line 73 in core/ui/src/main/java/org/phoebus/ui/color/NamedWidgetColors.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declare "ALARM_MINOR" and all following declarations on a separate line. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowWsPH6Y8hnMHh5J&open=AZyeowWsPH6Y8hnMHh5J&pullRequest=3716

Check warning on line 130 in core/ui/src/test/java/org/phoebus/ui/color/ColorUnitTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "TimeUnit.sleep()". 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZlPH6Y8hnMHh5f&open=AZyeowZlPH6Y8hnMHh5f&pullRequest=3716

Check warning on line 10 in core/ui/src/test/java/org/phoebus/ui/color/ColorUnitTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary import: same package classes are always implicitly imported. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZy5AiUFCmA7sYTHFFm6&open=AZy5AiUFCmA7sYTHFFm6&pullRequest=3716

Check warning on line 26 in core/ui/src/test/java/org/phoebus/ui/color/ColorUnitTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZlPH6Y8hnMHh5e&open=AZyeowZlPH6Y8hnMHh5e&pullRequest=3716

Check warning on line 17 in core/ui/src/main/java/org/phoebus/ui/color/WidgetColor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declare "green" and all following declarations on a separate line. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowY9PH6Y8hnMHh5O&open=AZyeowY9PH6Y8hnMHh5O&pullRequest=3716

Check warning on line 65 in core/ui/src/main/java/org/phoebus/ui/color/NamedWidgetColor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof NamedWidgetColor namedwidgetcolor' 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZVPH6Y8hnMHh5U&open=AZyeowZVPH6Y8hnMHh5U&pullRequest=3716

Check warning on line 32 in core/ui/src/test/java/org/phoebus/ui/color/ColorUnitTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZlPH6Y8hnMHh5b&open=AZyeowZlPH6Y8hnMHh5b&pullRequest=3716

Check warning on line 98 in core/ui/src/main/java/org/phoebus/ui/color/WidgetColorService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either re-interrupt this method or rethrow the "InterruptedException" that can be caught here. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZFPH6Y8hnMHh5S&open=AZyeowZFPH6Y8hnMHh5S&pullRequest=3716

Check warning on line 38 in core/ui/src/main/java/org/phoebus/ui/color/WidgetColorService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reorder the modifiers to comply with the Java Language Specification. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZFPH6Y8hnMHh5Q&open=AZyeowZFPH6Y8hnMHh5Q&pullRequest=3716

Check warning on line 96 in core/ui/src/test/java/org/phoebus/ui/color/ColorUnitTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZlPH6Y8hnMHh5d&open=AZyeowZlPH6Y8hnMHh5d&pullRequest=3716

Check warning on line 234 in core/ui/src/main/java/org/phoebus/ui/color/NamedWidgetColors.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowWsPH6Y8hnMHh5I&open=AZyeowWsPH6Y8hnMHh5I&pullRequest=3716

Check warning on line 114 in core/ui/src/test/java/org/phoebus/ui/color/ColorUnitTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZlPH6Y8hnMHh5a&open=AZyeowZlPH6Y8hnMHh5a&pullRequest=3716

Check warning on line 32 in core/ui/src/main/java/org/phoebus/ui/color/NamedWidgetColors.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this member "protected". 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowWsPH6Y8hnMHh5K&open=AZyeowWsPH6Y8hnMHh5K&pullRequest=3716

Check warning on line 49 in core/util/src/main/java/org/phoebus/util/config/ConfigFileParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZdPH6Y8hnMHh5V&open=AZyeowZdPH6Y8hnMHh5V&pullRequest=3716

Check warning on line 55 in core/ui/src/test/java/org/phoebus/ui/color/ColorUnitTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZlPH6Y8hnMHh5c&open=AZyeowZlPH6Y8hnMHh5c&pullRequest=3716

Check warning on line 223 in core/ui/src/main/java/org/phoebus/ui/color/NamedWidgetColors.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowWsPH6Y8hnMHh5H&open=AZyeowWsPH6Y8hnMHh5H&pullRequest=3716

Check warning on line 49 in core/util/src/main/java/org/phoebus/util/config/ConfigFileParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reorder the modifiers to comply with the Java Language Specification. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowZdPH6Y8hnMHh5Y&open=AZyeowZdPH6Y8hnMHh5Y&pullRequest=3716

Check warning on line 195 in core/ui/src/main/java/org/phoebus/ui/color/NamedWidgetColors.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch Exception instead of Throwable. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowWsPH6Y8hnMHh5N&open=AZyeowWsPH6Y8hnMHh5N&pullRequest=3716

Check warning on line 158 in core/ui/src/main/java/org/phoebus/ui/color/NamedWidgetColors.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZyeowWsPH6Y8hnMHh5L&open=AZyeowWsPH6Y8hnMHh5L&pullRequest=3716
View more details on SonarQubeCloud