Skip to content

Conversation

@Titas-Ghosh
Copy link

Hi @pradeeban ,This pr fixes issue #260

Why this change?

concore run defaults to --type windows on all platforms. On Linux/macOS this generates Windows scripts (.bat) and Windows commands, so the default Quick Start fails unless users override --type posix.


What was the problem?

  • CLI default is always windows
  • Non‑Windows users get Windows scripts by default
  • Default behavior is wrong on Linux/macOS

How I solved it

  1. Made the default --type OS-aware (windows on Windows, posix otherwise)
  2. Added a regression test to verify the generated build script matches the platform default

Changes / Implementation

  • concore_cli/cli.py
    • Dynamic default for --type
  • tests/test_cli.py
    • New test test_run_command_default_type

How to Test Locally

python -m pytest -v tests/test_cli.py
python -m pytest -v


Evidence

  • python -m pytest -v
    57 passed in 2.41s

PR Checklist

  • Added tests for the new behavior
  • Ran full test suite locally
  • No public API changes
  • Backwards-compatible (Windows default unchanged)

@pradeeban pradeeban merged commit 144158d into ControlCore-Project:dev Feb 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants