Skip to content

fix(github-app): reconnect uses POST /api/auth/login, not bare URL #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ABB65 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(github-app): reconnect uses POST /api/auth/login, not bare URL #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions app/components/organisms/ConnectRepoDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,11 +231,25 @@ async function connectExistingInstallation(installation: AvailableInstallation)
}
}

function reconnectGitHub() {
// Trigger Supabase GitHub OAuth flow; on return the OAuth callback
// captures and persists provider_token. After success, the user
// re-opens this dialog and the available list resolves.
window.location.href = `/api/auth/login?provider=github&redirect_to=${encodeURIComponent(window.location.pathname + window.location.search)}`
async function reconnectGitHub() {
// Trigger Supabase GitHub OAuth flow via the same POST endpoint
// (and CSRF-state cookie) that the standard sign-in screen uses.
// The auth callback handler captures `provider_token` and persists
// it via `auth/verify.post.ts` → DatabaseProvider.upsertOAuthProviderToken,
// so on return the user's available installations list will resolve.
//
// Save the current path so the user lands back here after callback —
// `useWorkspaces.saveLastPath` is what the workspace bootstrap reads
// when deciding where to redirect post-callback.
const { saveLastPath } = useWorkspaces()
const { signInWithOAuth } = useAuth()
saveLastPath(window.location.pathname + window.location.search)
try {
await signInWithOAuth('github')
}
catch (e: unknown) {
toast.error(resolveApiError(e, t('github.connect_existing_error')))
}
}

// Auto-detect GitHub App installation when user returns to tab
Expand Down
Loading