[AT-82]: add new quiz_asa_results_message type#458
Merged
esezen merged 4 commits intoJun 23, 2026
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dmitrycnstrc
changed the title
esezen
reviewed
Jun 5, 2026
| has_attribute: boolean; | ||
| is_matched: boolean; | ||
| }>; | ||
| quiz_asa_results_message?: Nullable<string>; |
Contributor
There was a problem hiding this comment.
Why do we need Nullable here? Would it ever be null?
Contributor
Author
There was a problem hiding this comment.
I've updated the quiz-service to make it optional instead. It's only included in the response when ASA returns at least one product result along with a message, so there's no scenario where it would be null. If there's no message, the field is simply omitted from the response
esezen
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new quiz_asa_results_message type for quizzes