[NO-REF] - introduce pia http module by vladconstructor · Pull Request #449 · Constructor-io/constructorio-client-javascript

vladconstructor · 2026-05-01T16:27:37Z

No description provided.

Copilot

Pull request overview

Introduces a new Product Insights Agent (PIA) HTTP module to the ConstructorIO client, including TypeScript typings and mocha specs, and exposes it as constructorio.pia.

Changes:

Added src/modules/pia.js with getSuggestedQuestions and getAnswerResults API methods.
Exposed the new module via src/constructorio.js and updated TypeScript declarations to include pia.
Added mocha specs for the new PIA module.

Reviewed changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/types/pia.d.ts	Adds TypeScript declarations for the new Pia module and its request/response types.
src/types/index.d.ts	Re-exports Pia types from the types entrypoint.
src/types/constructorio.d.ts	Adds `pia: Pia` to the ConstructorIO type surface and namespace exports.
src/modules/pia.js	Implements the Pia HTTP module (URL construction + fetch calls).
src/constructorio.js	Instantiates and exposes `this.pia` on the main client.
spec/src/modules/pia.js	Adds mocha coverage for suggested questions + answer results, including timeout cases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+  const {
+    apiKey,
+    clientId,
+    sessionId,
+    segments,
+    userId,
+    version,
+    agentServiceUrl,
+  } = options;


+    const controller = new AbortController();
+    const { signal } = controller;
+
+    try {
+      requestUrl = createPiaUrl(itemId, parameters, this.options, '');
+    } catch (e) {
+      return Promise.reject(e);
+    }
+
+    helpers.applyNetworkTimeout(this.options, networkParameters, controller);
+
+    return fetch(requestUrl, { signal })


+  getAnswerResults(itemId, question, parameters, networkParameters = {}) {
+    let requestUrl;
+    const { fetch } = this.options;
+    const controller = new AbortController();
+    const { signal } = controller;
+


vladconstructor · 2026-05-12T18:04:30Z

@claude

Copilot

Pull request overview

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 5 out of 8 changed files in this pull request and generated no new comments.

…rio-client-javascript into NO-REF/introduce-pia-http-module

esezen

Thanks for working on this, I left some small comments.

esezen · 2026-05-14T22:17:29Z

+    if (!question || typeof question !== 'string') {
+      return Promise.reject(new Error('question is a required parameter of type string'));
+    }


Can we move this up to come before AbortController so that we never even instantiate the AbortController if the question is not valid?

esezen · 2026-05-14T22:18:10Z

+          return json;
+        }
+
+        throw new Error('getSuggestedQuestions response data is malformed');


Can we add a test to check for this case?

esezen · 2026-05-14T22:18:48Z

+  }
+
+  if (parameters) {
+    const { threadId, variationId, numResults } = parameters;


Can we update the tests to check for threadId?

esezen · 2026-05-14T22:19:10Z

+      queryParams.variation_id = variationId;
+    }
+
+    if (!helpers.isNil(numResults)) {


Same as above, can we test this in one of the tests?

esezen · 2026-05-14T22:20:35Z

+}
+
+export interface PiaAnswerItemResults {
+  request?: Record<string, any>;


Is this actually very loose or do we know the shape of this? If we do, can we type it strictly? I know we have Record<string, any> in other parts of the library but we are trying to move away from that

…rio-client-javascript into NO-REF/introduce-pia-http-module

Mudaafi

lgtm! I had some questions, but if they're expected, we should be good.

Mudaafi · 2026-06-29T16:46:04Z

+    agentServiceUrl,
+    assistantServiceUrl,
+  } = options;
+  const serviceUrl = agentServiceUrl || assistantServiceUrl;


Will the serviceUrl always be the same as ASA? If they're different, maybe we should surface a separate top-level prop

I think they should always be the same. There are existing customers who are already integrated with PIA via API. I do not expect it to be changed any time soon.

Mudaafi · 2026-06-30T16:57:38Z

+  request?: {
+    item_id: string;
+    variation_id?: string;
+    num_results?: number;
+    thread_id?: string;
+  };


hmm, there are other fields in the request object (kind of like SABR), but there's no good type to extend it from. We can leave this as is for now.

Mudaafi · 2026-06-30T17:02:15Z

+      });
+    });
+
+    it('Should return a result provided a valid apiKey, itemId and variationId', () => {


it seems like variationId doesn't need to be valid to return a result. Is this expected?

Yes, this is expected. The test is verifying that the parameter gets passed through to the API correctly
(checking requestedUrlParams has variation_id), not that the API validates it. The API simply accepts whatever variationId is sent since it is a filtering/context parameter

[NO-REF] - introduce pia http module

39689da

Copilot AI review requested due to automatic review settings May 1, 2026 16:27

vladconstructor requested a review from a team as a code owner May 1, 2026 16:27

Copilot started reviewing on behalf of vladconstructor May 1, 2026 16:28 View session

Copilot AI reviewed May 1, 2026

View reviewed changes

vladconstructor marked this pull request as draft May 7, 2026 13:56

Address comments

4ebbbdd

vladconstructor marked this pull request as ready for review May 12, 2026 18:03

vladconstructor requested a review from Copilot May 12, 2026 18:04

Copilot started reviewing on behalf of vladconstructor May 12, 2026 18:05 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

Comment thread spec/src/modules/pia.js

Update CI

107617f

vladconstructor requested a review from Copilot May 12, 2026 18:17

Copilot started reviewing on behalf of vladconstructor May 12, 2026 18:17 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

vladconstructor added 2 commits May 14, 2026 16:19

Merge branch 'master' of https://github.com/Constructor-io/constructo…

de96242

…rio-client-javascript into NO-REF/introduce-pia-http-module

Add a timeout for tests

f610990

esezen requested changes May 14, 2026

View reviewed changes

vladconstructor added 2 commits June 18, 2026 21:01

code restructure

f8ab9ac

Merge branch 'master' of https://github.com/Constructor-io/constructo…

2337772

…rio-client-javascript into NO-REF/introduce-pia-http-module

vladconstructor requested a review from esezen June 22, 2026 17:20

Mudaafi approved these changes Jun 30, 2026

View reviewed changes

Uh oh!

Conversation

vladconstructor commented May 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

vladconstructor commented May 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

esezen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mudaafi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants