Open
Conversation
Before this change:
$ make
gcc -c -g -O3 -Wunused-variable -DFONTDIR='"/usr/local/share/dcled"' \
-DDCLEDVERSION='"2.2"' \
-I/usr/include/libusb-1.0 dcled.c
dcled.c: In function ‘open_usbdev’:
dcled.c:265:3: warning: ‘libusb_set_debug’ is deprecated: \
Use libusb_set_option instead [-Wdeprecated-declarations]
libusb_set_debug(NULL,3);
^~~~~~~~~~~~~~~~
In file included from dcled.c:30:
/usr/include/libusb-1.0/libusb.h:1300:18: note: declared here
void LIBUSB_CALL libusb_set_debug(libusb_context *ctx, int level);
^~~~~~~~~~~~~~~~
dcled.c: In function ‘printBCDchar’:
dcled.c:409:7: warning: implicit declaration of function ‘isdigit’ \
[-Wimplicit-function-declaration]
if (!isdigit(c)) {
^~~~~~~
dcled.c: In function ‘savefonts’:
dcled.c:1375:30: warning: implicit declaration of function ‘isgraph’ \
[-Wimplicit-function-declaration]
fprintf(out,"%02x %c ",i,(isgraph(i)?i:'.'));
^~~~~~~
gcc dcled.o -o dcled -g -lm -lusb-1.0
gcc -c -g -O3 -Wunused-variable -DFONTDIR='"/usr/local/share/dcled"' \
-DDCLEDVERSION='"2.2"' \
-I/usr/include/libusb-1.0 cpuload.c
cpuload.c: In function ‘main’:
cpuload.c:85:7: warning: implicit declaration of function ‘strcmp’ \
[-Wimplicit-function-declaration]
if(!strcmp(tag,"cpu ")) {
^~~~~~
gcc cpuload.o -o cpuload -g -lm -lusb-1.0
$
After this change:
$ make
gcc -c -g -O3 -Wunused-variable -DFONTDIR='"/usr/local/share/dcled"' \
-DDCLEDVERSION='"2.2"' -I/usr/include/libusb-1.0 dcled.c
gcc dcled.o -o dcled -g -lm -lusb-1.0
gcc -c -g -O3 -Wunused-variable -DFONTDIR='"/usr/local/share/dcled"' \
-DDCLEDVERSION='"2.2"' -I/usr/include/libusb-1.0 cpuload.c
gcc cpuload.o -o cpuload -g -lm -lusb-1.0
$
Member
Author
|
I'm probably not going to merge this pull request into the Conservatory copy of the code. At the same time, though I'm not prepared to take over maintenance of dcled. So I'm just making the PR visible for now, in case anyone else runs into these compile-time warnings. If I hear from other folks here, that'll be a sign that maybe I should actively maintain @kfogel/dcled after all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change:
After this change: