Fixed phpcs

lib/BackgroundJob/HookRetryJob.php

@@ -55,7 +55,7 @@ class HookRetryJob extends QueuedJob
      * Constructor for HookRetryJob
      *
      * @param ITimeFactory           $time                Time factory
-     * @param MagicMapper     $objectEntityMapper  Object mapper
+     * @param MagicMapper            $objectEntityMapper  Object mapper
      * @param SchemaMapper           $schemaMapper        Schema mapper
      * @param WorkflowEngineRegistry $engineRegistry      Engine registry
      * @param CloudEventFormatter    $cloudEventFormatter CloudEvent formatter

lib/Controller/ConfigurationController.php

@@ -1242,7 +1242,8 @@ private function importFromSource(callable $fetchConfig, array $params, string $
 
             $configuration = $this->configurationMapper->insert($configuration);
 
-            $msg = '[ConfigurationController] Created configuration'." entity with ID {$configuration->getId()} for app {$appId}";
+            $configId = $configuration->getId();
+            $msg      = "[ConfigurationController] Created configuration entity with ID {$configId} for app {$appId}";
             $this->logger->info(
                 message: $msg,
                 context: ['file' => __FILE__, 'line' => __LINE__]
@@ -1267,7 +1268,8 @@ private function importFromSource(callable $fetchConfig, array $params, string $
             // But we need to save the sync status.
             $this->configurationMapper->update($configuration);
 
-            $msg = '[ConfigurationController] Successfully imported'." configuration {$configuration->getTitle()} from {$sourceType}";
+            $configTitle = $configuration->getTitle();
+            $msg         = "[ConfigurationController] Successfully imported configuration {$configTitle} from {$sourceType}";
             $this->logger->info(
                 message: $msg,
                 context: ['file' => __FILE__, 'line' => __LINE__]

lib/Controller/DeletedController.php

@@ -44,13 +44,13 @@
     /**
      * Constructor for the DeletedController
      *
-     * @param string             $appName            The name of the app
-     * @param IRequest           $request            The request object
-     * @param MagicMapper $objectEntityMapper The object entity mapper
-     * @param RegisterMapper     $registerMapper     The register mapper
-     * @param SchemaMapper       $schemaMapper       The schema mapper
-     * @param ObjectService      $objectService      The object service
-     * @param IUserSession       $userSession        The user session
+     * @param string         $appName            The name of the app
+     * @param IRequest       $request            The request object
+     * @param MagicMapper    $objectEntityMapper The object entity mapper
+     * @param RegisterMapper $registerMapper     The register mapper
+     * @param SchemaMapper   $schemaMapper       The schema mapper
+     * @param ObjectService  $objectService      The object service
+     * @param IUserSession   $userSession        The user session
      *
      * @return void
      */
@@ -260,13 +260,13 @@
         try {
             // Get total deleted count.
             $totalDeleted = $this->objectEntityMapper->countAll(
                 _filters: ['@self.deleted' => 'IS NOT NULL'],
             );
 
             // Get deleted today count.
             $today        = (new DateTime())->format('Y-m-d');
             $deletedToday = $this->objectEntityMapper->countAll(
                 _filters: [
                     '@self.deleted'         => 'IS NOT NULL',
                     '@self.deleted.deleted' => '>='.$today,
                 ],
@@ -275,7 +275,7 @@
             // Get deleted this week count.
             $weekAgo         = (new DateTime())->modify('-7 days')->format('Y-m-d');
             $deletedThisWeek = $this->objectEntityMapper->countAll(
                 _filters: [
                     '@self.deleted'         => 'IS NOT NULL',
                     '@self.deleted.deleted' => '>='.$weekAgo,
                 ],

lib/Controller/HealthController.php

@@ -78,10 +78,18 @@ public function index(): JSONResponse
         // Check filesystem.
         $checks['filesystem'] = $this->checkFilesystem();
         if ($checks['filesystem'] !== 'ok') {
-            $status = ($status === 'error') ? 'error' : 'degraded';
+            if ($status === 'error') {
+                $status = 'error';
+            } else {
+                $status = 'degraded';
+            }
         }
 
-        $httpStatus = ($status === 'ok') ? Http::STATUS_OK : Http::STATUS_SERVICE_UNAVAILABLE;
+        if ($status === 'ok') {
+            $httpStatus = Http::STATUS_OK;
+        } else {
+            $httpStatus = Http::STATUS_SERVICE_UNAVAILABLE;
+        }
 
         return new JSONResponse(
             [
@@ -109,7 +117,7 @@ private function checkDatabase(): string
             return 'ok';
         } catch (\Exception $e) {
             $this->logger->error('[HealthController] Database check failed', ['error' => $e->getMessage()]);
-            return 'failed: ' . $e->getMessage();
+            return 'failed: '.$e->getMessage();
         }
     }//end checkDatabase()
 
@@ -121,7 +129,7 @@ private function checkDatabase(): string
     private function checkFilesystem(): string
     {
         try {
-            $tmpFile = sys_get_temp_dir() . '/openregister_health_' . getmypid();
+            $tmpFile = sys_get_temp_dir().'/openregister_health_'.getmypid();
             $written = file_put_contents($tmpFile, 'health');
             if ($written === false) {
                 return 'failed: cannot write to temp directory';
@@ -131,7 +139,7 @@ private function checkFilesystem(): string
 
             return 'ok';
         } catch (\Exception $e) {
-            return 'failed: ' . $e->getMessage();
+            return 'failed: '.$e->getMessage();
         }
     }//end checkFilesystem()
 

lib/Controller/MetricsController.php

@@ -91,7 +91,7 @@ private function collectMetrics(): string
 
         $lines[] = '# HELP openregister_info Application information';
         $lines[] = '# TYPE openregister_info gauge';
-        $lines[] = 'openregister_info{version="' . $version . '",php_version="' . $phpVersion . '"} 1';
+        $lines[] = 'openregister_info{version="'.$version.'",php_version="'.$phpVersion.'"} 1';
         $lines[] = '';
 
         // App up gauge.
@@ -101,40 +101,40 @@ private function collectMetrics(): string
         $lines[] = '';
 
         // Registers total.
-        $registersTotal = $this->countTable('openregister_registers');
+        $registersTotal = $this->countTable(table: 'openregister_registers');
         $lines[]        = '# HELP openregister_registers_total Total number of registers';
         $lines[]        = '# TYPE openregister_registers_total gauge';
-        $lines[]        = 'openregister_registers_total ' . $registersTotal;
+        $lines[]        = 'openregister_registers_total '.$registersTotal;
         $lines[]        = '';
 
         // Schemas total.
-        $schemasTotal = $this->countTable('openregister_schemas');
+        $schemasTotal = $this->countTable(table: 'openregister_schemas');
         $lines[]      = '# HELP openregister_schemas_total Total number of schemas';
         $lines[]      = '# TYPE openregister_schemas_total gauge';
-        $lines[]      = 'openregister_schemas_total ' . $schemasTotal;
+        $lines[]      = 'openregister_schemas_total '.$schemasTotal;
         $lines[]      = '';
 
         // Objects total (by register and schema).
-        $lines[] = '# HELP openregister_objects_total Total objects by register and schema';
-        $lines[] = '# TYPE openregister_objects_total gauge';
+        $lines[]      = '# HELP openregister_objects_total Total objects by register and schema';
+        $lines[]      = '# TYPE openregister_objects_total gauge';
         $objectCounts = $this->getObjectCountsByRegisterAndSchema();
         foreach ($objectCounts as $row) {
-            $register = $this->sanitizeLabel($row['register_name'] ?? 'unknown');
-            $schema   = $this->sanitizeLabel($row['schema_name'] ?? 'unknown');
+            $register = $this->sanitizeLabel(value: $row['register_name'] ?? 'unknown');
+            $schema   = $this->sanitizeLabel(value: $row['schema_name'] ?? 'unknown');
             $count    = (int) $row['object_count'];
-            $lines[]  = 'openregister_objects_total{register="' . $register . '",schema="' . $schema . '"} ' . $count;
+            $lines[]  = 'openregister_objects_total{register="'.$register.'",schema="'.$schema.'"} '.$count;
         }
 
         $lines[] = '';
 
         // Search requests total (from metrics table if it exists).
-        $searchCount = $this->countMetricsByType('search_');
+        $searchCount = $this->countMetricsByType(typePrefix: 'search_');
         $lines[]     = '# HELP openregister_search_requests_total Total search requests';
         $lines[]     = '# TYPE openregister_search_requests_total counter';
-        $lines[]     = 'openregister_search_requests_total ' . $searchCount;
+        $lines[]     = 'openregister_search_requests_total '.$searchCount;
         $lines[]     = '';
 
-        return implode("\n", $lines) . "\n";
+        return implode("\n", $lines)."\n";
     }//end collectMetrics()
 
     /**
@@ -156,7 +156,7 @@ private function countTable(string $table): int
 
             return (int) ($row['cnt'] ?? 0);
         } catch (\Exception $e) {
-            $this->logger->warning('[MetricsController] Failed to count table ' . $table, ['error' => $e->getMessage()]);
+            $this->logger->warning('[MetricsController] Failed to count table '.$table, ['error' => $e->getMessage()]);
             return 0;
         }
     }//end countTable()
@@ -201,7 +201,7 @@ private function countMetricsByType(string $typePrefix): int
             $qb = $this->db->getQueryBuilder();
             $qb->select($qb->func()->count('*', 'cnt'))
                 ->from('openregister_metrics')
-                ->where($qb->expr()->like('metric_type', $qb->createNamedParameter($typePrefix . '%')));
+                ->where($qb->expr()->like('metric_type', $qb->createNamedParameter($typePrefix.'%')));
 
             $result = $qb->executeQuery();
             $row    = $result->fetch();

lib/Controller/ObjectsController.php

@@ -93,21 +93,21 @@
     /**
      * Constructor for the ObjectsController
      *
-     * @param string             $appName            The name of the app
-     * @param IRequest           $request            The request object
-     * @param IAppConfig         $config             The app configuration object
-     * @param IAppManager        $appManager         The app manager
-     * @param ContainerInterface $container          The DI container
-     * @param RegisterMapper     $registerMapper     The register mapper
-     * @param SchemaMapper       $schemaMapper       The schema mapper
-     * @param AuditTrailMapper   $auditTrailMapper   The audit trail mapper
-     * @param ObjectService      $objectService      The object service
-     * @param IUserSession       $userSession        The user session
-     * @param IGroupManager      $groupManager       The group manager
-     * @param ExportService      $exportService      The export service
-     * @param ImportService      $importService      The import service
-     * @param WebhookService     $webhookService     The webhook service (optional)
-     * @param LoggerInterface    $logger             The logger (optional)
+     * @param string             $appName          The name of the app
+     * @param IRequest           $request          The request object
+     * @param IAppConfig         $config           The app configuration object
+     * @param IAppManager        $appManager       The app manager
+     * @param ContainerInterface $container        The DI container
+     * @param RegisterMapper     $registerMapper   The register mapper
+     * @param SchemaMapper       $schemaMapper     The schema mapper
+     * @param AuditTrailMapper   $auditTrailMapper The audit trail mapper
+     * @param ObjectService      $objectService    The object service
+     * @param IUserSession       $userSession      The user session
+     * @param IGroupManager      $groupManager     The group manager
+     * @param ExportService      $exportService    The export service
+     * @param ImportService      $importService    The import service
+     * @param WebhookService     $webhookService   The webhook service (optional)
+     * @param LoggerInterface    $logger           The logger (optional)
      *
      * @return void
      *
@@ -525,7 +525,7 @@
             'offset'  => $offset,
             'page'    => $page,
             'filters' => $params,
-            'sort'    => $this->normalizeOrderParameter($params['order'] ?? $params['_order'] ?? []),
+            'sort'    => $this->normalizeOrderParameter(order: $params['order'] ?? $params['_order'] ?? []),
             '_search' => ($params['_search'] ?? null),
             '_extend' => $this->normalizeExtendParameter(extend: $params['extend'] ?? $params['_extend'] ?? null),
             '_fields' => ($params['fields'] ?? $params['_fields'] ?? null),
@@ -955,8 +955,8 @@
         $rbac   = filter_var($params['rbac'] ?? true, FILTER_VALIDATE_BOOLEAN);
         // Check both _multi and multi params (URL uses _multi, but we also support multi).
         $multiExplicitlySet = isset($params['_multi']) || isset($params['multi']);
-        $multi     = filter_var($params['_multi'] ?? $params['multi'] ?? true, FILTER_VALIDATE_BOOLEAN);
-        $deleted   = filter_var($params['deleted'] ?? false, FILTER_VALIDATE_BOOLEAN);
+        $multi   = filter_var($params['_multi'] ?? $params['multi'] ?? true, FILTER_VALIDATE_BOOLEAN);
+        $deleted = filter_var($params['deleted'] ?? false, FILTER_VALIDATE_BOOLEAN);
 
         // Check if magic mapping is enabled for this register+schema.
         $registerEntity = $resolved['registerEntity'] ?? null;
@@ -2304,7 +2304,7 @@
             $deleteHandler = $objectService->getDeleteHandler();
             $analysis      = $deleteHandler->canDelete($objectEntity);
 
             return new JSONResponse(data: $analysis->toArray(), statusCode: 200);
         } catch (\OCP\AppFramework\Db\DoesNotExistException $exception) {
             return new JSONResponse(data: ['error' => 'Object not found'], statusCode: 404);
         } catch (\Exception $exception) {

lib/Controller/RegistersController.php

@@ -151,7 +151,7 @@ class RegistersController extends Controller
      * @param string               $appName              Application name
      * @param IRequest             $request              HTTP request object
      * @param RegisterService      $registerService      Register service for business logic
-     * @param MagicMapper   $objectEntityMapper   Object entity mapper for database operations
+     * @param MagicMapper          $objectEntityMapper   Object entity mapper for database operations
      * @param UploadService        $uploadService        Upload service for file uploads
      * @param LoggerInterface      $logger               Logger for error tracking
      * @param IUserSession         $userSession          User session service
@@ -303,7 +303,9 @@ public function index(): JSONResponse
                             schemas: $expandedSchemas
                         );
 
-                        $msg = '[RegistersController] Schema counts for register '.$register['id'].': '.json_encode($schemaCounts);
+                        $registerId = $register['id'];
+                        $countsJson = json_encode($schemaCounts);
+                        $msg        = "[RegistersController] Schema counts for register {$registerId}: {$countsJson}";
                         $this->logger->debug(
                             message: $msg,
                             context: ['file' => __FILE__, 'line' => __LINE__]
@@ -326,7 +328,8 @@ public function index(): JSONResponse
                                 $schema['stats'] = [
                                     'objects' => $schemaCounts[$schemaId],
                                 ];
-                                $msg = '[RegistersController] Set stats for schema '."{$schemaId}: ".json_encode($schema['stats']);
+                                $statsJson       = json_encode($schema['stats']);
+                                $msg = "[RegistersController] Set stats for schema {$schemaId}: {$statsJson}";
                                 $this->logger->debug(
                                     message: $msg,
                                     context: ['file' => __FILE__, 'line' => __LINE__]

lib/Controller/SchemasController.php

@@ -82,7 +82,7 @@
      * @param IRequest            $request             HTTP request object
      * @param IAppConfig          $config              App configuration for settings
      * @param SchemaMapper        $schemaMapper        Schema mapper for database operations
-     * @param MagicMapper  $objectEntityMapper  Object entity mapper for object queries
+     * @param MagicMapper         $objectEntityMapper  Object entity mapper for object queries
      * @param DownloadService     $downloadService     Download service for file downloads
      * @param UploadService       $uploadService       Upload service for file uploads
      * @param AuditTrailMapper    $auditTrailMapper    Audit trail mapper for log statistics
@@ -222,7 +222,7 @@
 
             // Batch-load all statistics in 3 queries instead of N*2 queries.
             $registerCounts = $this->schemaMapper->getRegisterCountPerSchema();
             $objectStats    = $this->objectEntityMapper->getStatisticsGroupedBySchema(schemaIds: $schemaIds);
             $logStats       = $this->auditTrailMapper->getStatisticsGroupedBySchema(schemaIds: $schemaIds);
 
             foreach ($schemasArr as &$schema) {

lib/Db/AbstractObjectMapper.php

@@ -57,8 +57,8 @@ abstract class AbstractObjectMapper
      * @param Register|null $register       Optional register to filter by.
      * @param Schema|null   $schema         Optional schema to filter by.
      * @param bool          $includeDeleted Whether to include deleted objects.
-     * @param bool          $_rbac           Whether to apply RBAC checks (default: true).
-     * @param bool          $_multitenancy   Whether to apply multitenancy filtering (default: true).
+     * @param bool          $_rbac          Whether to apply RBAC checks (default: true).
+     * @param bool          $_multitenancy  Whether to apply multitenancy filtering (default: true).
      *
      * @return ObjectEntity The found object.
      *
@@ -300,8 +300,8 @@ abstract public function getFacetableFieldsFromSchemas(array $baseQuery=[]): arr
      *
      * @param array       $query         Query parameters.
      * @param string|null $activeOrgUuid Active organisation UUID.
-     * @param bool        $_rbac          Whether to apply RBAC checks.
-     * @param bool        $_multitenancy  Whether to apply multitenancy filtering.
+     * @param bool        $_rbac         Whether to apply RBAC checks.
+     * @param bool        $_multitenancy Whether to apply multitenancy filtering.
      * @param array|null  $ids           Array of IDs or UUIDs to filter by.
      * @param string|null $uses          Value that must be present in relations.
      *
@@ -325,8 +325,8 @@ abstract public function searchObjects(
      *
      * @param array       $query         Query parameters.
      * @param string|null $activeOrgUuid Active organisation UUID.
-     * @param bool        $_rbac          Whether to apply RBAC checks.
-     * @param bool        $_multitenancy  Whether to apply multitenancy filtering.
+     * @param bool        $_rbac         Whether to apply RBAC checks.
+     * @param bool        $_multitenancy Whether to apply multitenancy filtering.
      * @param array|null  $ids           Array of IDs or UUIDs to filter by.
      * @param string|null $uses          Value that must be present in relations.
      *

lib/Db/AuditTrailMapper.php

@@ -61,7 +61,7 @@ class AuditTrailMapper extends QBMapper
     /**
      * Constructor for the AuditTrailMapper
      *
-     * @param IDBConnection      $db                 The database connection
+     * @param IDBConnection                     $db        The database connection
      * @param \Psr\Container\ContainerInterface $container DI container for lazy mapper resolution
      */
     public function __construct(
@@ -439,7 +439,7 @@ public function revertObject($identifier, $until=null, bool $overwriteVersion=fa
     {
         // Get the current object (lazy-resolved to avoid circular DI).
         $objectMapper = $this->container->get(MagicMapper::class);
-        $object = $objectMapper->find($identifier);
+        $object       = $objectMapper->find($identifier);
 
         // Get audit trail entries until the specified point.
         $auditTrails = $this->findByObjectUntil(