Migrate webhooks views/modals to shared components and standardize form CSS#1250
Merged
SudoThijn merged 4 commits intofeature/nextcloud-vue-package-usagefrom Mar 31, 2026
Conversation
according to inheritance rules I cannot and should not add it to CnTabbedFormDialog
remko48
approved these changes
Mar 31, 2026
SudoThijn
merged commit c288bff
into
feature/nextcloud-vue-package-usage
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CnIndexPagecomponent, replacing custom table/filter/pagination logicCnIndexPagewith URL-based routing via optional webhook ID parameter; fixed dropdown filter showing IDs instead of names; fixed webhook column displaying "#undefined"NcDialog+ bootstrap-vue layout toCnTabbedFormDialogpatternCnDetailCardandCnJsonViewer(with multi-language support for response body rendering).field-hint,.selectField,.checkboxField, and dropdown option styles (.option-content,.option-title,.option-description,.option-meta) to EditApplication, EditConfiguration, and EditOrganisationwebhooksLogsDetailsroute and controller method for direct URL access to webhook logs (/webhooks/logs/{id})Changes
Webhook views (2 files):
WebhooksIndex and WebhookLogsIndex rewritten with CnIndexPage — net reduction of ~570 lines.
Webhook modals (2 files):
EditWebhook migrated to CnTabbedFormDialog, ViewWebhookLog simplified with CnDetailCard/CnJsonViewer.
Form modals CSS (3 files):
EditApplication, EditConfiguration, EditOrganisation updated with standardized form field and dropdown option styles.
Backend (2 files):
New route in
routes.phpandUiController::webhooksLogsDetails()for/webhooks/logs/{id}.Router (1 file):
Updated frontend route to accept optional webhook ID parameter.
Requires: ConductionNL/nextcloud-vue#40