Skip to content

Release: merge development into beta#90

Open
github-actions[bot] wants to merge 29 commits intobetafrom
development
Open

Release: merge development into beta#90
github-actions[bot] wants to merge 29 commits intobetafrom
development

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Automated PR to sync development changes to beta for beta release.

Merging this PR will trigger the beta release workflow.

Reminder: Add a major, minor, or patch label to this PR to control the version bump. Default is patch.

…conflicts

Downgrade devDependencies to match @nextcloud/eslint-config@8.4.x peer
requirements (@vue/eslint-config-typescript ^13, eslint-plugin-vue ^9,
eslint-plugin-n ^16, eslint-plugin-promise ^6, eslint-plugin-jsdoc ^46).
Add missing production dependencies (@nextcloud/auth, vue-apexcharts).
Fix eslint errors (html-indent, duplicate imports). Add license override
for apexcharts (MIT-licensed but reports custom SPDX string).
fix: Resolve all CI quality check failures
@github-actions
Copy link
Copy Markdown
Contributor Author

Quality Report

Repository ConductionNL/larpingapp
Commit e341203
Branch 90/merge
Event pull_request
Generated 2026-03-19 18:55 UTC
Workflow Run https://github.com/ConductionNL/larpingapp/actions/runs/23311646375

Summary

Group Result
PHP Quality PASS
Vue Quality PASS
Security PASS
License PASS
PHPUnit SKIP
Newman SKIP

PHP Quality

Tool Result
lint PASS
phpcs PASS
phpmd PASS
psalm PASS
phpstan PASS
phpmetrics PASS

Vue Quality

Tool Result
eslint PASS
stylelint PASS

Security

Ecosystem Result
composer PASS
npm PASS

License Compliance

Ecosystem Result
composer PASS
npm PASS

composer dependencies (94 total)

Metric Count
Approved (allowlist) 94
Approved (override) 0
Denied 0

npm dependencies (248 total)

Metric Count
Approved (allowlist) 247
Approved (override) 1
Denied 0

PHPUnit Tests

PHPUnit tests were not enabled for this run.

Integration Tests (Newman)

Newman integration tests were not enabled for this run.


Generated automatically by the Quality workflow.

Download the full PDF report from the workflow artifacts.

@github-actions
Copy link
Copy Markdown
Contributor Author

Quality Report

Repository ConductionNL/larpingapp
Commit 473e6d9
Branch 90/merge
Event pull_request
Generated 2026-03-19 18:58 UTC
Workflow Run https://github.com/ConductionNL/larpingapp/actions/runs/23311789570

Summary

Group Result
PHP Quality PASS
Vue Quality PASS
Security PASS
License PASS
PHPUnit SKIP
Newman SKIP

PHP Quality

Tool Result
lint PASS
phpcs PASS
phpmd PASS
psalm PASS
phpstan PASS
phpmetrics PASS

Vue Quality

Tool Result
eslint PASS
stylelint PASS

Security

Ecosystem Result
composer PASS
npm PASS

License Compliance

Ecosystem Result
composer PASS
npm PASS

composer dependencies (94 total)

Metric Count
Approved (allowlist) 94
Approved (override) 0
Denied 0

npm dependencies (248 total)

Metric Count
Approved (allowlist) 247
Approved (override) 1
Denied 0

PHPUnit Tests

PHPUnit tests were not enabled for this run.

Integration Tests (Newman)

Newman integration tests were not enabled for this run.


Generated automatically by the Quality workflow.

Download the full PDF report from the workflow artifacts.

@github-actions
Copy link
Copy Markdown
Contributor Author

Quality Report

Repository ConductionNL/larpingapp
Commit e047e5b
Branch 90/merge
Event pull_request
Generated 2026-03-19 19:05 UTC
Workflow Run https://github.com/ConductionNL/larpingapp/actions/runs/23312031182

Summary

Group Result
PHP Quality PASS
Vue Quality PASS
Security PASS
License PASS
PHPUnit SKIP
Newman SKIP

PHP Quality

Tool Result
lint PASS
phpcs PASS
phpmd PASS
psalm PASS
phpstan PASS
phpmetrics PASS

Vue Quality

Tool Result
eslint PASS
stylelint PASS

Security

Ecosystem Result
composer PASS
npm PASS

License Compliance

Ecosystem Result
composer PASS
npm PASS

composer dependencies (94 total)

Metric Count
Approved (allowlist) 94
Approved (override) 0
Denied 0

npm dependencies (248 total)

Metric Count
Approved (allowlist) 247
Approved (override) 1
Denied 0

PHPUnit Tests

PHPUnit tests were not enabled for this run.

Integration Tests (Newman)

Newman integration tests were not enabled for this run.


Generated automatically by the Quality workflow.

Download the full PDF report from the workflow artifacts.

@github-actions
Copy link
Copy Markdown
Contributor Author

Quality Report

Repository ConductionNL/larpingapp
Commit f41b40e
Branch 90/merge
Event pull_request
Generated 2026-03-19 19:09 UTC
Workflow Run https://github.com/ConductionNL/larpingapp/actions/runs/23312246198

Summary

Group Result
PHP Quality PASS
Vue Quality PASS
Security PASS
License PASS
PHPUnit SKIP
Newman SKIP

PHP Quality

Tool Result
lint PASS
phpcs PASS
phpmd PASS
psalm PASS
phpstan PASS
phpmetrics PASS

Vue Quality

Tool Result
eslint PASS
stylelint PASS

Security

Ecosystem Result
composer PASS
npm PASS

License Compliance

Ecosystem Result
composer PASS
npm PASS

composer dependencies (94 total)

Metric Count
Approved (allowlist) 94
Approved (override) 0
Denied 0

npm dependencies (248 total)

Metric Count
Approved (allowlist) 247
Approved (override) 1
Denied 0

PHPUnit Tests

PHPUnit tests were not enabled for this run.

Integration Tests (Newman)

Newman integration tests were not enabled for this run.


Generated automatically by the Quality workflow.

Download the full PDF report from the workflow artifacts.

@github-actions
Copy link
Copy Markdown
Contributor Author

Quality Report

Repository ConductionNL/larpingapp
Commit 0644c0a
Branch 90/merge
Event pull_request
Generated 2026-03-19 19:12 UTC
Workflow Run https://github.com/ConductionNL/larpingapp/actions/runs/23312369818

Summary

Group Result
PHP Quality PASS
Vue Quality PASS
Security PASS
License PASS
PHPUnit SKIP
Newman SKIP

PHP Quality

Tool Result
lint PASS
phpcs PASS
phpmd PASS
psalm PASS
phpstan PASS
phpmetrics PASS

Vue Quality

Tool Result
eslint PASS
stylelint PASS

Security

Ecosystem Result
composer PASS
npm PASS

License Compliance

Ecosystem Result
composer PASS
npm PASS

composer dependencies (94 total)

Metric Count
Approved (allowlist) 94
Approved (override) 0
Denied 0

npm dependencies (248 total)

Metric Count
Approved (allowlist) 247
Approved (override) 1
Denied 0

PHPUnit Tests

PHPUnit tests were not enabled for this run.

Integration Tests (Newman)

Newman integration tests were not enabled for this run.


Generated automatically by the Quality workflow.

Download the full PDF report from the workflow artifacts.

@github-actions
Copy link
Copy Markdown
Contributor Author

Quality Report

Repository ConductionNL/larpingapp
Commit 68e5a77
Branch 90/merge
Event pull_request
Generated 2026-03-19 21:37 UTC
Workflow Run https://github.com/ConductionNL/larpingapp/actions/runs/23318051893

Summary

Group Result
PHP Quality PASS
Vue Quality PASS
Security PASS
License PASS
PHPUnit SKIP
Newman SKIP

PHP Quality

Tool Result
lint PASS
phpcs PASS
phpmd PASS
psalm PASS
phpstan PASS
phpmetrics PASS

Vue Quality

Tool Result
eslint PASS
stylelint PASS

Security

Ecosystem Result
composer PASS
npm PASS

License Compliance

Ecosystem Result
composer PASS
npm PASS

composer dependencies (94 total)

Metric Count
Approved (allowlist) 94
Approved (override) 0
Denied 0

npm dependencies (248 total)

Metric Count
Approved (allowlist) 247
Approved (override) 1
Denied 0

PHPUnit Tests

PHPUnit tests were not enabled for this run.

Integration Tests (Newman)

Newman integration tests were not enabled for this run.


Generated automatically by the Quality workflow.

Download the full PDF report from the workflow artifacts.

The compiled JS contained a hard gate that showed 'OpenRegister is required'
and blocked all UI routes. Replaced with a non-blocking NcNoteCard warning
banner that allows the app to render normally while informing users about
the missing configuration.
All specs moved from openspec/specs/ to openspec/changes/ with proper
proposal.md as the entry point. Follows the spec-driven workflow:
proposal -> design -> specs -> tasks
Add ADR references to the rules section of openspec/config.yaml so that
ADR constraints are injected into openspec instructions output during
artifact creation.
- 9 new SettingsServiceTest tests (CONFIG_KEYS, get/update, delegation)
- Fixed SettingsControllerTest constructor (all 6 deps)
- Feature doc with browser screenshot
- Merged JS build fix for settings page rendering
- Removed deprecated template entity type from spec
Full pipeline complete: proposal → design → specs → tasks → apply → verify → archive
- 16/16 tasks completed
- 9 unit tests added (SettingsServiceTest)
- Feature doc with browser screenshot
- Delta spec synced to openspec/specs/admin-settings/ as implemented baseline
Process all active OpenSpec changes through the full pipeline:

Changes processed:
- character-management: Character CRUD, stat calculation engine
- dashboard: KPI cards, recent lists, skill chart widget layout
- events-players: Event/player CRUD, event effect application
- game-mechanics: Abilities, Effects, Skills, Items, Conditions
- larping-skill-widget: GraphQL faceting donut chart
- object-service: RegisterObjectFetcher data access layer
- pdf-export: DocuDesk PDF character sheet export
- rpg-system: Stat calculation pipeline with audit trail
- search-service: Dead code documentation (removed)
- register-config-json: Auto-import schemas on boot
- user-settings: Settings dialog with re-import
- deep-link-registration: Unified search URL patterns

Implementation:
- Created DeepLinkRegistrationListener for 8 object types
- Registered listener in Application.php
- Fixed named parameter bug in CharactersController cross-app calls

Tests added (60 total, 152 assertions):
- CharacterServiceTest (12 tests)
- RegisterObjectFetcherTest (6 tests)
- CharactersControllerTest (5 tests)
- DashboardControllerTest (4 tests)
- ConfigFileLoaderServiceTest (5 tests)
- SettingsMapBuilderTest (8 tests)
- DeepLinkRegistrationListenerTest (4 tests)

Documentation: 12 feature docs + 6 screenshots created
Specs: All 12 synced to openspec/specs/ and archived
Update documentation link from non-existent larpingapp.com
to valid Gitbook URL.
Make ADR-011 more specific: list concrete directories to search
and common duplications to prevent future utility reimplementations.
Unit tests MUST run inside the Docker container, not locally.
Prevents false test failure reports from missing Nextcloud framework.
Adds a features overview document for the LARP campaign management app,
covering character management, RPG game mechanics, events/players, PDF export,
OpenRegister integration, and dashboard widget.
[Docs] Feature overview with GEMMA/TEC standards
@github-actions
Copy link
Copy Markdown
Contributor Author

Quality Report

Repository ConductionNL/larpingapp
Commit 2aef093
Branch 90/merge
Event pull_request
Generated 2026-03-23 21:38 UTC
Workflow Run https://github.com/ConductionNL/larpingapp/actions/runs/23461376504

Summary

Group Result
PHP Quality PASS
Vue Quality FAIL
Security PASS
License PASS
PHPUnit SKIP
Newman SKIP

PHP Quality

Tool Result
lint PASS
phpcs PASS
phpmd PASS
psalm PASS
phpstan PASS
phpmetrics PASS

Vue Quality

Tool Result
eslint FAIL
stylelint PASS

Security

Ecosystem Result
composer PASS
npm PASS

License Compliance

Ecosystem Result
composer PASS
npm PASS

composer dependencies (94 total)

Metric Count
Approved (allowlist) 94
Approved (override) 0
Denied 0

npm dependencies (248 total)

Metric Count
Approved (allowlist) 247
Approved (override) 1
Denied 0

PHPUnit Tests

PHPUnit tests were not enabled for this run.

Integration Tests (Newman)

Newman integration tests were not enabled for this run.


Generated automatically by the Quality workflow.

Download the full PDF report from the workflow artifacts.

@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Apr 9, 2026

Quality Report

Repository ConductionNL/larpingapp
Commit 3fded4f
Branch 90/merge
Event pull_request
Generated 2026-04-09 09:47 UTC
Workflow Run https://github.com/ConductionNL/larpingapp/actions/runs/24183657526

Summary

Group Result
PHP Quality PASS
Vue Quality FAIL
Security PASS
License PASS
PHPUnit SKIP
Newman SKIP
Playwright SKIP

PHP Quality

Tool Result
lint PASS
phpcs PASS
phpmd PASS
psalm PASS
phpstan PASS
phpmetrics PASS

Vue Quality

Tool Result
eslint FAIL
stylelint PASS

Security

Ecosystem Result
composer PASS
npm PASS

License Compliance

Ecosystem Result
composer PASS
npm PASS

composer dependencies (94 total)

Metric Count
Approved (allowlist) 94
Approved (override) 0
Denied 0

npm dependencies (248 total)

Metric Count
Approved (allowlist) 247
Approved (override) 1
Denied 0

PHPUnit Tests

PHPUnit tests were not enabled for this run.

Integration Tests (Newman)

Newman integration tests were not enabled for this run.

E2E Tests (Playwright)

Playwright E2E tests were not enabled for this run.


Generated automatically by the Quality workflow.

Download the full PDF report from the workflow artifacts.

@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Apr 9, 2026

Quality Report

Repository ConductionNL/larpingapp
Commit f2c3b5d
Branch 90/merge
Event pull_request
Generated 2026-04-09 10:24 UTC
Workflow Run https://github.com/ConductionNL/larpingapp/actions/runs/24184200585

Summary

Group Result
PHP Quality PASS
Vue Quality FAIL
Security PASS
License PASS
PHPUnit SKIP
Newman SKIP
Playwright SKIP

PHP Quality

Tool Result
lint PASS
phpcs PASS
phpmd PASS
psalm PASS
phpstan PASS
phpmetrics PASS

Vue Quality

Tool Result
eslint FAIL
stylelint PASS

Security

Ecosystem Result
composer PASS
npm PASS

License Compliance

Ecosystem Result
composer PASS
npm PASS

composer dependencies (94 total)

Metric Count
Approved (allowlist) 94
Approved (override) 0
Denied 0

npm dependencies (248 total)

Metric Count
Approved (allowlist) 247
Approved (override) 1
Denied 0

PHPUnit Tests

PHPUnit tests were not enabled for this run.

Integration Tests (Newman)

Newman integration tests were not enabled for this run.

E2E Tests (Playwright)

Playwright E2E tests were not enabled for this run.


Generated automatically by the Quality workflow.

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant