Skip to content

E-Board Vote#93

Merged
tallen42 merged 6 commits intodevfrom
eboard-vote
Mar 5, 2026
Merged

E-Board Vote#93
tallen42 merged 6 commits intodevfrom
eboard-vote

Conversation

@tallen42
Copy link
Contributor

@tallen42 tallen42 commented Mar 5, 2026

What

Adds E-Board Vote
also PR template thing since i'm here

Why

So E-Board can do "heads-down" votes on Vote

Test Plan

local test

Screenshot From 2026-03-05 13-49-39

Env Vars

Dev variable DEV_FORCE_IS_CHAIR

Checklist

  • Tested all changes locally

@pikachu0542
Copy link
Member

What is the "simple vote"? Is that just the normal voting method of select 1 option and anyone can vote?

Copy link
Contributor

@BigSpaceships BigSpaceships left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but one small formatting thing

Comment on lines +66 to +81
<span>Ranked Choice Vote</span>
<input
type="radio"
name="pollType"
value="eboard"
class="ml-3"
>
<span>E-Board Vote</span>
<input
type="radio"
name="pollType"
value="simple"
class="ml-3"
checked="checked"
>
<span>Simple (Single-Choice) Vote</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix indentation here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@csh-sonarqube-community
Copy link

Failed Quality Gate failed

  • 0.00% Coverage on New Code (is less than 80.00%)

Project ID: ComputerScienceHouse_vote_c5ba863d-30d7-4fa9-97dd-4f2c58f8f5fa

View in SonarQube

Copy link
Contributor

@BigSpaceships BigSpaceships left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tallen42 tallen42 merged commit 7931034 into dev Mar 5, 2026
2 of 3 checks passed
@BigSpaceships BigSpaceships deleted the eboard-vote branch March 5, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants