yamllint: cover all changed files ending in yaml, yml or fmf#14601
yamllint: cover all changed files ending in yaml, yml or fmf#14601vojtapolasek wants to merge 5 commits intoComplianceAsCode:masterfrom
Conversation
.github/workflows/ci_lint.yml
Outdated
| if: ${{ env.CONTROLS_CHANGES == 'true' }} | ||
| run: | | ||
| for control_file in $(cat filenames.txt | grep "controls/"); do | ||
| for control_file in $(cat filenames.txt | grep "controls/.*\.yml"); do |
There was a problem hiding this comment.
There is a similar regex on line 32. Should that regex be changed as well?
|
Are you sure you don't want to configure |
8ca69d6 to
d48dd28
Compare
Filter out files inside the .yamllint configuration
also enforce line length of 99
d48dd28 to
975e2d6
Compare
b803433 to
02bffa8
Compare
|
@vojtapolasek: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
jan-cerny
left a comment
There was a problem hiding this comment.
@vojtapolasek Do I understand it well that now the .profile files won't be checked?
Description:
Rationale:
grep "controls/"pattern matched any file path containingcontrols/, which could include non-YAML files that yamllint cannot process. Restricting tocontrols/.*\.ymlensures only relevant YAML files are linted, avoiding spurious CI failures.Review Hints:
.github/workflows/ci_lint.yml(line 52).